Re: [PATCH v2 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-29 Thread Thomas Gleixner
On Wed, 23 Dec 2015, Steven Rostedt wrote: > On Sun, 6 Dec 2015 10:02:58 +0800 > Li Bin wrote: > > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > > index 311bcf3..db0f6b1 100644 > > --- a/arch/x86/kernel/ftrace.c > > +++ b/arch/x86/kernel/ftrace.c > > @@ -106,13 +106,11 @@

Re: [PATCH v2 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-29 Thread Thomas Gleixner
On Wed, 23 Dec 2015, Steven Rostedt wrote: > On Sun, 6 Dec 2015 10:02:58 +0800 > Li Bin wrote: > > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > > index 311bcf3..db0f6b1 100644 > > --- a/arch/x86/kernel/ftrace.c > > +++ b/arch/x86/kernel/ftrace.c > >

Re: [PATCH v2 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-23 Thread Steven Rostedt
On Sun, 6 Dec 2015 10:02:58 +0800 Li Bin wrote: > There is no need to worry about module and __init text disappearing > case, because that ftrace has a module notifier that is called when > a module is being unloaded and before the text goes away and this > code grabs the ftrace_lock mutex and

Re: [PATCH v2 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-23 Thread Steven Rostedt
On Sun, 6 Dec 2015 10:02:58 +0800 Li Bin wrote: > There is no need to worry about module and __init text disappearing > case, because that ftrace has a module notifier that is called when > a module is being unloaded and before the text goes away and this > code grabs

[PATCH v2 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-05 Thread Li Bin
There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such

[PATCH v2 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct

2015-12-05 Thread Li Bin
There is no need to worry about module and __init text disappearing case, because that ftrace has a module notifier that is called when a module is being unloaded and before the text goes away and this code grabs the ftrace_lock mutex and removes the module functions from the ftrace list, such