Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Shevchenko, Andriy
On Thu, 2015-11-26 at 19:58 +0200, Andy Shevchenko wrote: > On Thu, 2015-11-26 at 23:11 +0530, Vinod Koul wrote: > > On Thu, Nov 26, 2015 at 07:24:48PM +0200, Andy Shevchenko wrote: > > > On Thu, 2015-11-26 at 22:31 +0530, Vinod Koul wrote: > > > > On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy

Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Andy Shevchenko
On Thu, 2015-11-26 at 23:11 +0530, Vinod Koul wrote: > On Thu, Nov 26, 2015 at 07:24:48PM +0200, Andy Shevchenko wrote: > > On Thu, 2015-11-26 at 22:31 +0530, Vinod Koul wrote: > > > On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy Shevchenko wrote: > > > > We have to call dw_dma_disable() to stop

Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Vinod Koul
On Thu, Nov 26, 2015 at 07:24:48PM +0200, Andy Shevchenko wrote: > On Thu, 2015-11-26 at 22:31 +0530, Vinod Koul wrote: > > On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy Shevchenko wrote: > > > We have to call dw_dma_disable() to stop any ongoing transfer. > > > > Ok > > > > > On some platforms

Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Andy Shevchenko
On Thu, 2015-11-26 at 22:31 +0530, Vinod Koul wrote: > On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy Shevchenko wrote: > > We have to call dw_dma_disable() to stop any ongoing transfer. > > Ok > > > On some platforms we can't do that since DMA device is powered off. > > Umm, you said we have

Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Vinod Koul
On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy Shevchenko wrote: > We have to call dw_dma_disable() to stop any ongoing transfer. Ok > On some platforms we can't do that since DMA device is powered off. Umm, you said we have ongoing transfer which means DMA should be on..!! > Moreover we have

[PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Andy Shevchenko
We have to call dw_dma_disable() to stop any ongoing transfer. On some platforms we can't do that since DMA device is powered off. Moreover we have no possibility at that point to check if the platform is affected or not. That's why we call pm_runtime_get_sync() / pm_runtime_put() unconditionally.

[PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Andy Shevchenko
We have to call dw_dma_disable() to stop any ongoing transfer. On some platforms we can't do that since DMA device is powered off. Moreover we have no possibility at that point to check if the platform is affected or not. That's why we call pm_runtime_get_sync() / pm_runtime_put() unconditionally.

Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Vinod Koul
On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy Shevchenko wrote: > We have to call dw_dma_disable() to stop any ongoing transfer. Ok > On some platforms we can't do that since DMA device is powered off. Umm, you said we have ongoing transfer which means DMA should be on..!! > Moreover we have

Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Andy Shevchenko
On Thu, 2015-11-26 at 22:31 +0530, Vinod Koul wrote: > On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy Shevchenko wrote: > > We have to call dw_dma_disable() to stop any ongoing transfer. > > Ok > > > On some platforms we can't do that since DMA device is powered off. > > Umm, you said we have

Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Vinod Koul
On Thu, Nov 26, 2015 at 07:24:48PM +0200, Andy Shevchenko wrote: > On Thu, 2015-11-26 at 22:31 +0530, Vinod Koul wrote: > > On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy Shevchenko wrote: > > > We have to call dw_dma_disable() to stop any ongoing transfer. > > > > Ok > > > > > On some platforms

Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Andy Shevchenko
On Thu, 2015-11-26 at 23:11 +0530, Vinod Koul wrote: > On Thu, Nov 26, 2015 at 07:24:48PM +0200, Andy Shevchenko wrote: > > On Thu, 2015-11-26 at 22:31 +0530, Vinod Koul wrote: > > > On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy Shevchenko wrote: > > > > We have to call dw_dma_disable() to stop

Re: [PATCH v2 5/7] dmaengine: dw: platform: power on device on shutdown

2015-11-26 Thread Shevchenko, Andriy
On Thu, 2015-11-26 at 19:58 +0200, Andy Shevchenko wrote: > On Thu, 2015-11-26 at 23:11 +0530, Vinod Koul wrote: > > On Thu, Nov 26, 2015 at 07:24:48PM +0200, Andy Shevchenko wrote: > > > On Thu, 2015-11-26 at 22:31 +0530, Vinod Koul wrote: > > > > On Thu, Nov 26, 2015 at 05:19:11PM +0200, Andy