Re: [PATCH v2 5/8] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures

2018-02-27 Thread Borislav Petkov
On Tue, Feb 27, 2018 at 03:33:44PM +, Ghannam, Yazen wrote: > I agree which is why I've included the Validation Bits. A user can then > check the Validation Bits for any field that is of interest but missing. No, no half-baked fields. So you know drivers/edac/mce_amd.c, right? And you know th

RE: [PATCH v2 5/8] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures

2018-02-27 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov [mailto:b...@suse.de] > Sent: Tuesday, February 27, 2018 10:04 AM > To: Ghannam, Yazen > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > ard.biesheu...@linaro.org; x...@kernel.org > Subject: Re: [PATCH v2

Re: [PATCH v2 5/8] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures

2018-02-27 Thread Borislav Petkov
On Mon, Feb 26, 2018 at 01:39:01PM -0600, Yazen Ghannam wrote: > +static void print_err_info(const char *pfx, u8 err_type, u64 check) > +{ > + u16 validation_bits = CHECK_VALID_BITS(check); > + > + printk("%sValidation Bits: 0x%04x\n", pfx, validation_bits); > + > + if (err_type == ERR_

[PATCH v2 5/8] efi: Decode IA32/X64 Cache, TLB, and Bus Check structures

2018-02-26 Thread Yazen Ghannam
From: Yazen Ghannam Print the common fields of the Cache, TLB, and Bus check structures.The fields of these three check types are the same except for a few more fields in the Bus check structure. The remaining Bus check structure fields will be decoded in a following patch. Based on UEFI 2.7, Ta