Re: [PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-03-08 Thread Prabhakar Lad
Sekhar, On Mon, Feb 4, 2013 at 10:33 AM, Prabhakar Lad wrote: > Sekhar , > > On Sun, Feb 3, 2013 at 6:15 PM, Sekhar Nori wrote: >> On 1/28/2013 7:17 PM, Prabhakar Lad wrote: >>> From: Lad, Prabhakar >>> >>> The system configuration chip CFGCHIP3, controls the emac module. >>> This patch

Re: [PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-03-08 Thread Prabhakar Lad
Sekhar, On Mon, Feb 4, 2013 at 10:33 AM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Sekhar , On Sun, Feb 3, 2013 at 6:15 PM, Sekhar Nori nsek...@ti.com wrote: On 1/28/2013 7:17 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com The system configuration chip CFGCHIP3,

Re: [PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-02-03 Thread Sekhar Nori
On 2/3/2013 6:15 PM, Sekhar Nori wrote: > On 1/28/2013 7:17 PM, Prabhakar Lad wrote: >> From: Lad, Prabhakar > There are couple of issues with this implementation. > > 1) da8xx_config_emac() is specific to DA850 EVM, but masquerades as >generic for da8xx. Looks like you need two functions,

Re: [PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-02-03 Thread Prabhakar Lad
Sekhar , On Sun, Feb 3, 2013 at 6:15 PM, Sekhar Nori wrote: > On 1/28/2013 7:17 PM, Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> The system configuration chip CFGCHIP3, controls the emac module. >> This patch appropriately configures this register for emac and >> sets

Re: [PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-02-03 Thread Sekhar Nori
On 1/28/2013 7:17 PM, Prabhakar Lad wrote: > From: Lad, Prabhakar > > The system configuration chip CFGCHIP3, controls the emac module. > This patch appropriately configures this register for emac and > sets DA850_MII_MDIO_CLKEN_PIN GPIO pin appropriately. > > Signed-off-by: Lad, Prabhakar >

Re: [PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-02-03 Thread Prabhakar Lad
Sekhar , On Sun, Feb 3, 2013 at 6:15 PM, Sekhar Nori nsek...@ti.com wrote: On 1/28/2013 7:17 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com The system configuration chip CFGCHIP3, controls the emac module. This patch appropriately configures this register for emac and

Re: [PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-02-03 Thread Sekhar Nori
On 2/3/2013 6:15 PM, Sekhar Nori wrote: On 1/28/2013 7:17 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com There are couple of issues with this implementation. 1) da8xx_config_emac() is specific to DA850 EVM, but masquerades as generic for da8xx. Looks like you need

Re: [PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-02-03 Thread Sekhar Nori
On 1/28/2013 7:17 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com The system configuration chip CFGCHIP3, controls the emac module. This patch appropriately configures this register for emac and sets DA850_MII_MDIO_CLKEN_PIN GPIO pin appropriately. Signed-off-by: Lad,

[PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-01-28 Thread Prabhakar Lad
From: Lad, Prabhakar The system configuration chip CFGCHIP3, controls the emac module. This patch appropriately configures this register for emac and sets DA850_MII_MDIO_CLKEN_PIN GPIO pin appropriately. Signed-off-by: Lad, Prabhakar Cc: linux-arm-ker...@lists.infradead.org Cc:

[PATCH v2 6/6] ARM: davinci: da850: configure system configuration chip(CFGCHIP3) for emac

2013-01-28 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com The system configuration chip CFGCHIP3, controls the emac module. This patch appropriately configures this register for emac and sets DA850_MII_MDIO_CLKEN_PIN GPIO pin appropriately. Signed-off-by: Lad, Prabhakar prabhakar@ti.com Cc: