Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-15 Thread Simon Glass
Hi Dmitry, On Thu, Feb 14, 2013 at 9:31 AM, Dmitry Torokhov wrote: > On Wed, Feb 13, 2013 at 10:45:07PM -0800, Simon Glass wrote: >> >> >> >> +config KEYBOARD_CROS_EC >> >> + tristate "ChromeOS EC keyboard" >> >> + select INPUT_MATRIXKMAP >> >> + select MFD_CROS_EC >> > >> > Is this

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-15 Thread Simon Glass
Hi Dmitry, On Thu, Feb 14, 2013 at 9:31 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Feb 13, 2013 at 10:45:07PM -0800, Simon Glass wrote: +config KEYBOARD_CROS_EC + tristate ChromeOS EC keyboard + select INPUT_MATRIXKMAP + select MFD_CROS_EC Is this

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-14 Thread Dmitry Torokhov
On Wed, Feb 13, 2013 at 10:45:07PM -0800, Simon Glass wrote: > >> > >> +config KEYBOARD_CROS_EC > >> + tristate "ChromeOS EC keyboard" > >> + select INPUT_MATRIXKMAP > >> + select MFD_CROS_EC > > > > Is this select safe? I.e. does MFD_CROS_EC depend on anything else? > > I'll remove

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-14 Thread Dmitry Torokhov
On Wed, Feb 13, 2013 at 10:45:07PM -0800, Simon Glass wrote: +config KEYBOARD_CROS_EC + tristate ChromeOS EC keyboard + select INPUT_MATRIXKMAP + select MFD_CROS_EC Is this select safe? I.e. does MFD_CROS_EC depend on anything else? I'll remove it, since it isn't

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-13 Thread Simon Glass
Hi Dmitry, On Wed, Feb 13, 2013 at 12:02 PM, Dmitry Torokhov wrote: > Hi SImon, > > On Tue, Feb 12, 2013 at 06:42:26PM -0800, Simon Glass wrote: >> Use the key-matrix layer to interpret key scan information from the EC >> and inject input based on the FDT-supplied key map. This driver registers

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-13 Thread Dmitry Torokhov
Hi SImon, On Tue, Feb 12, 2013 at 06:42:26PM -0800, Simon Glass wrote: > Use the key-matrix layer to interpret key scan information from the EC > and inject input based on the FDT-supplied key map. This driver registers > itself with the ChromeOS EC driver to perform communications. > >

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-13 Thread Dmitry Torokhov
Hi SImon, On Tue, Feb 12, 2013 at 06:42:26PM -0800, Simon Glass wrote: Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC driver to perform communications. Additional

Re: [PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-13 Thread Simon Glass
Hi Dmitry, On Wed, Feb 13, 2013 at 12:02 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi SImon, On Tue, Feb 12, 2013 at 06:42:26PM -0800, Simon Glass wrote: Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This

[PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-12 Thread Simon Glass
Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC driver to perform communications. Additional FDT bindings are provided to specify rows/columns and the auto-repeat

[PATCH v2 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-12 Thread Simon Glass
Use the key-matrix layer to interpret key scan information from the EC and inject input based on the FDT-supplied key map. This driver registers itself with the ChromeOS EC driver to perform communications. Additional FDT bindings are provided to specify rows/columns and the auto-repeat