Re: [PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_private

2013-07-29 Thread Steven Rostedt
On Tue, 2013-07-30 at 10:28 +0900, Masami Hiramatsu wrote: > (2013/07/29 23:21), Oleg Nesterov wrote: > > On 07/29, Masami Hiramatsu wrote: > >> > >> (2013/07/27 2:25), Oleg Nesterov wrote: > >>> Change remove_event_file_dir() to clear ->i_private for every > >>> file we are going to remove. > >>

Re: [PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_private

2013-07-29 Thread Masami Hiramatsu
(2013/07/29 23:21), Oleg Nesterov wrote: > On 07/29, Masami Hiramatsu wrote: >> >> (2013/07/27 2:25), Oleg Nesterov wrote: >>> Change remove_event_file_dir() to clear ->i_private for every >>> file we are going to remove. >> >> Oleg, I think this should be done first. >> >> AFAICS, your former

Re: [PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_private

2013-07-29 Thread Oleg Nesterov
On 07/29, Masami Hiramatsu wrote: > > (2013/07/27 2:25), Oleg Nesterov wrote: > > Change remove_event_file_dir() to clear ->i_private for every > > file we are going to remove. > > Oleg, I think this should be done first. > > AFAICS, your former patches depend strongly on this change. > Without

Re: [PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_private

2013-07-29 Thread Masami Hiramatsu
(2013/07/27 2:25), Oleg Nesterov wrote: > Change remove_event_file_dir() to clear ->i_private for every > file we are going to remove. Oleg, I think this should be done first. AFAICS, your former patches depend strongly on this change. Without this, they don't work as you expected, and it may

Re: [PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear d_subdirs-i_private

2013-07-29 Thread Masami Hiramatsu
(2013/07/27 2:25), Oleg Nesterov wrote: Change remove_event_file_dir() to clear -i_private for every file we are going to remove. Oleg, I think this should be done first. AFAICS, your former patches depend strongly on this change. Without this, they don't work as you expected, and it may

Re: [PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear d_subdirs-i_private

2013-07-29 Thread Oleg Nesterov
On 07/29, Masami Hiramatsu wrote: (2013/07/27 2:25), Oleg Nesterov wrote: Change remove_event_file_dir() to clear -i_private for every file we are going to remove. Oleg, I think this should be done first. AFAICS, your former patches depend strongly on this change. Without this, they

Re: [PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear d_subdirs-i_private

2013-07-29 Thread Masami Hiramatsu
(2013/07/29 23:21), Oleg Nesterov wrote: On 07/29, Masami Hiramatsu wrote: (2013/07/27 2:25), Oleg Nesterov wrote: Change remove_event_file_dir() to clear -i_private for every file we are going to remove. Oleg, I think this should be done first. AFAICS, your former patches depend strongly

Re: [PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear d_subdirs-i_private

2013-07-29 Thread Steven Rostedt
On Tue, 2013-07-30 at 10:28 +0900, Masami Hiramatsu wrote: (2013/07/29 23:21), Oleg Nesterov wrote: On 07/29, Masami Hiramatsu wrote: (2013/07/27 2:25), Oleg Nesterov wrote: Change remove_event_file_dir() to clear -i_private for every file we are going to remove. Oleg, I think this

[PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear "d_subdirs"->i_private

2013-07-26 Thread Oleg Nesterov
Change remove_event_file_dir() to clear ->i_private for every file we are going to remove. tracing_open_generic_file() and tracing_release_generic_file() can go away, ftrace_enable_fops and ftrace_event_filter_fops() use tracing_open_generic() but only to check tracing_disabled. This fixes all

[PATCH v2 6/6] tracing: Change remove_event_file_dir() to clear d_subdirs-i_private

2013-07-26 Thread Oleg Nesterov
Change remove_event_file_dir() to clear -i_private for every file we are going to remove. tracing_open_generic_file() and tracing_release_generic_file() can go away, ftrace_enable_fops and ftrace_event_filter_fops() use tracing_open_generic() but only to check tracing_disabled. This fixes all