Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-22 Thread Andrew Lunn
> as of now it isn't even an API, the phy_device populates a new array > in its struct with the values from the DT. PHY drivers access the > array directly. Is it still preferable to post everything together? > > (maybe I'm too concerned about 'noise' from the driver patches while > we are

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-22 Thread Matthias Kaehlcke
Hi Andrew, On Mon, Jul 22, 2019 at 09:01:33PM +0200, Andrew Lunn wrote: > On Mon, Jul 22, 2019 at 10:14:18AM -0700, Matthias Kaehlcke wrote: > > I'm working on a generic binding. > > > > I wonder what is the best process for reviewing/landing it, I'm > > doubting between two options: > > > > a)

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-22 Thread Andrew Lunn
On Mon, Jul 22, 2019 at 10:14:18AM -0700, Matthias Kaehlcke wrote: > I'm working on a generic binding. > > I wonder what is the best process for reviewing/landing it, I'm > doubting between two options: > > a) only post the binding doc and the generic PHY code that reads >the configuration

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-22 Thread Matthias Kaehlcke
On Wed, Jul 10, 2019 at 09:55:12AM -0600, Rob Herring wrote: > On Wed, Jul 3, 2019 at 5:23 PM Matthias Kaehlcke wrote: > > > > Hi Florian, > > > > On Wed, Jul 03, 2019 at 02:37:47PM -0700, Florian Fainelli wrote: > > > On 7/3/19 12:37 PM, Matthias Kaehlcke wrote: > > > > The LED behavior of some

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-12 Thread Matthias Kaehlcke
Hi Florian, On Wed, Jul 10, 2019 at 09:28:39AM -0700, Florian Fainelli wrote: > On 7/10/19 8:55 AM, Rob Herring wrote: > > On Wed, Jul 3, 2019 at 5:23 PM Matthias Kaehlcke wrote: > >> > >> Hi Florian, > >> > >> On Wed, Jul 03, 2019 at 02:37:47PM -0700, Florian Fainelli wrote: > >>> On 7/3/19

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-12 Thread Matthias Kaehlcke
On Wed, Jul 10, 2019 at 09:55:12AM -0600, Rob Herring wrote: > On Wed, Jul 3, 2019 at 5:23 PM Matthias Kaehlcke wrote: > > > > Hi Florian, > > > > On Wed, Jul 03, 2019 at 02:37:47PM -0700, Florian Fainelli wrote: > > > On 7/3/19 12:37 PM, Matthias Kaehlcke wrote: > > > > The LED behavior of some

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-10 Thread Florian Fainelli
On 7/10/19 8:55 AM, Rob Herring wrote: > On Wed, Jul 3, 2019 at 5:23 PM Matthias Kaehlcke wrote: >> >> Hi Florian, >> >> On Wed, Jul 03, 2019 at 02:37:47PM -0700, Florian Fainelli wrote: >>> On 7/3/19 12:37 PM, Matthias Kaehlcke wrote: The LED behavior of some Realtek PHYs is configurable.

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-10 Thread Rob Herring
On Wed, Jul 3, 2019 at 5:23 PM Matthias Kaehlcke wrote: > > Hi Florian, > > On Wed, Jul 03, 2019 at 02:37:47PM -0700, Florian Fainelli wrote: > > On 7/3/19 12:37 PM, Matthias Kaehlcke wrote: > > > The LED behavior of some Realtek PHYs is configurable. Add the > > > property 'realtek,led-modes' to

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-03 Thread Matthias Kaehlcke
Hi Florian, On Wed, Jul 03, 2019 at 02:37:47PM -0700, Florian Fainelli wrote: > On 7/3/19 12:37 PM, Matthias Kaehlcke wrote: > > The LED behavior of some Realtek PHYs is configurable. Add the > > property 'realtek,led-modes' to specify the configuration of the > > LEDs. > > > > Signed-off-by:

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-03 Thread Florian Fainelli
On 7/3/19 12:37 PM, Matthias Kaehlcke wrote: > The LED behavior of some Realtek PHYs is configurable. Add the > property 'realtek,led-modes' to specify the configuration of the > LEDs. > > Signed-off-by: Matthias Kaehlcke > --- > Changes in v2: > - patch added to the series > --- >

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-03 Thread Heiner Kallweit
On 03.07.2019 22:13, Heiner Kallweit wrote: > On 03.07.2019 21:37, Matthias Kaehlcke wrote: >> The LED behavior of some Realtek PHYs is configurable. Add the >> property 'realtek,led-modes' to specify the configuration of the >> LEDs. >> >> Signed-off-by: Matthias Kaehlcke >> --- >> Changes in

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-03 Thread Heiner Kallweit
On 03.07.2019 21:37, Matthias Kaehlcke wrote: > The LED behavior of some Realtek PHYs is configurable. Add the > property 'realtek,led-modes' to specify the configuration of the > LEDs. > > Signed-off-by: Matthias Kaehlcke > --- > Changes in v2: > - patch added to the series > --- >

Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-03 Thread Andrew Lunn
On Wed, Jul 03, 2019 at 12:37:23PM -0700, Matthias Kaehlcke wrote: Hi Matthias Maybe add a #define for 0, so we know what it does. > +#define RTL8211E_LINK_10 1 > +#define RTL8211E_LINK_1002 > +#define RTL8211E_LINK_1000 4

[PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode

2019-07-03 Thread Matthias Kaehlcke
The LED behavior of some Realtek PHYs is configurable. Add the property 'realtek,led-modes' to specify the configuration of the LEDs. Signed-off-by: Matthias Kaehlcke --- Changes in v2: - patch added to the series --- .../devicetree/bindings/net/realtek.txt | 9 +