Re: [PATCH v2 6/7] mtd: nand: raw: make BBT code more generic

2016-11-16 Thread Boris Brezillon
On Thu, 17 Nov 2016 14:19:29 +0800 Peter Pan wrote: > Hi Boris, > > On Sun, Oct 16, 2016 at 10:35 PM, Boris Brezillon > wrote: > > BBT support is currently tightly tied to raw NAND, though this is the kind > > of code we could share across all NAND based devices, no matter what > > physical int

Re: [PATCH v2 6/7] mtd: nand: raw: make BBT code more generic

2016-11-16 Thread Peter Pan
Hi Boris, On Sun, Oct 16, 2016 at 10:35 PM, Boris Brezillon wrote: > BBT support is currently tightly tied to raw NAND, though this is the kind > of code we could share across all NAND based devices, no matter what > physical interface is to communicate with the NAND chip. > > Make BBT code inter

Re: [PATCH v2 6/7] mtd: nand: raw: make BBT code more generic

2016-11-16 Thread Boris Brezillon
On Wed, 16 Nov 2016 16:43:58 +0800 Peter Pan wrote: > Hi Boris, > > I found a bug during my review. Please see below. > > On Sun, Oct 16, 2016 at 10:35 PM, Boris Brezillon > wrote: > > BBT support is currently tightly tied to raw NAND, though this is the kind > > of code we could share across

Re: [PATCH v2 6/7] mtd: nand: raw: make BBT code more generic

2016-11-16 Thread Peter Pan
Hi Boris, I found a bug during my review. Please see below. On Sun, Oct 16, 2016 at 10:35 PM, Boris Brezillon wrote: > BBT support is currently tightly tied to raw NAND, though this is the kind > of code we could share across all NAND based devices, no matter what > physical interface is to comm

[PATCH v2 6/7] mtd: nand: raw: make BBT code more generic

2016-10-16 Thread Boris Brezillon
BBT support is currently tightly tied to raw NAND, though this is the kind of code we could share across all NAND based devices, no matter what physical interface is to communicate with the NAND chip. Make BBT code interface agnostic by replacing all occurrence of struct nand_chip by struct nand_d