2019年5月8日(水) 9:25 Minwoo Im :
>
> > This is a bit of a mine field. The shutdown_lock is held when reclaiming
> > requests that didn't see a response. If you're holding it here and your
> > telemetry log page times out, we're going to deadlock. And since the
> > controller is probably in a buggered
2019年5月8日(水) 6:28 Keith Busch :
>
> On Tue, May 07, 2019 at 02:31:41PM -0600, Heitke, Kenneth wrote:
> > On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> > > +
> > > +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void
> > > *buf,
> > > +size_t
> This is a bit of a mine field. The shutdown_lock is held when reclaiming
> requests that didn't see a response. If you're holding it here and your
> telemetry log page times out, we're going to deadlock. And since the
> controller is probably in a buggered state when you try to retrieve one,
> I
On Tue, May 07, 2019 at 02:31:41PM -0600, Heitke, Kenneth wrote:
> On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> > +
> > +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void *buf,
> > +size_t bytes, loff_t offset)
> > +{
> > + const size_t
On 5/7/2019 10:58 AM, Akinobu Mita wrote:
+
+static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void *buf,
+size_t bytes, loff_t offset)
+{
+ const size_t chunk_size = ctrl->max_hw_sectors * ctrl->page_size;
Just curious if
On 5/7/2019 10:58 AM, Akinobu Mita wrote:
This enables to capture snapshot of controller information via device
coredump machanism.
s/machanism/mechanism/
The nvme device coredump creates the following coredump files.
- regs: NVMe controller registers (00h to 4Fh)
- sq: Submission queue
On Wed, May 08, 2019 at 01:58:33AM +0900, Akinobu Mita wrote:
> +static void nvme_coredump(struct device *dev)
> +{
> + struct nvme_dev *ndev = dev_get_drvdata(dev);
> +
> + mutex_lock(>shutdown_lock);
> +
> + nvme_coredump_prologue(ndev);
> + nvme_coredump_epilogue(ndev);
> +
> +
This enables to capture snapshot of controller information via device
coredump machanism.
The nvme device coredump creates the following coredump files.
- regs: NVMe controller registers (00h to 4Fh)
- sq: Submission queue
- cq: Completion queue
- telemetry-ctrl-log: Telemetry
8 matches
Mail list logo
