Re: [PATCH v2 6/7] udf: Remove struct ustr as non-needed intermediate storage

2016-01-04 Thread Jan Kara
On Thu 24-12-15 10:25:37, Andrew Gabbasov wrote: > Although 'struct ustr' tries to structurize the data by combining > the string and its length, it doesn't actually make much benefit, > since it saves only one parameter, but introduces an extra copying > of the whole buffer, serving as an

Re: [PATCH v2 6/7] udf: Remove struct ustr as non-needed intermediate storage

2016-01-04 Thread Jan Kara
On Thu 24-12-15 10:25:37, Andrew Gabbasov wrote: > Although 'struct ustr' tries to structurize the data by combining > the string and its length, it doesn't actually make much benefit, > since it saves only one parameter, but introduces an extra copying > of the whole buffer, serving as an

[PATCH v2 6/7] udf: Remove struct ustr as non-needed intermediate storage

2015-12-24 Thread Andrew Gabbasov
Although 'struct ustr' tries to structurize the data by combining the string and its length, it doesn't actually make much benefit, since it saves only one parameter, but introduces an extra copying of the whole buffer, serving as an intermediate storage. It looks quite inefficient and not

[PATCH v2 6/7] udf: Remove struct ustr as non-needed intermediate storage

2015-12-24 Thread Andrew Gabbasov
Although 'struct ustr' tries to structurize the data by combining the string and its length, it doesn't actually make much benefit, since it saves only one parameter, but introduces an extra copying of the whole buffer, serving as an intermediate storage. It looks quite inefficient and not