Re: [PATCH v2 6/8] x86/microcode: Recheck IBRS features on microcode reload

2018-01-08 Thread Borislav Petkov
On Fri, Jan 05, 2018 at 06:12:21PM -0800, Tim Chen wrote: > On new microcode write, check whether IBRS > is present by rescanning IBRS feature. > > Signed-off-by: Tim Chen > --- > arch/x86/include/asm/spec_ctrl.h | 1 + > arch/x86/kernel/cpu/microcode/core.c |

Re: [PATCH v2 6/8] x86/microcode: Recheck IBRS features on microcode reload

2018-01-08 Thread Borislav Petkov
On Fri, Jan 05, 2018 at 06:12:21PM -0800, Tim Chen wrote: > On new microcode write, check whether IBRS > is present by rescanning IBRS feature. > > Signed-off-by: Tim Chen > --- > arch/x86/include/asm/spec_ctrl.h | 1 + > arch/x86/kernel/cpu/microcode/core.c | 4 >

Re: [PATCH v2 6/8] x86/microcode: Recheck IBRS features on microcode reload

2018-01-06 Thread Woodhouse, David
On Fri, 2018-01-05 at 18:12 -0800, Tim Chen wrote: > On new microcode write, check whether IBRS > is present by rescanning IBRS feature. > > Signed-off-by: Tim Chen Didn't we also give you a patch which fixed up the error handling on the microcode reload, when it

Re: [PATCH v2 6/8] x86/microcode: Recheck IBRS features on microcode reload

2018-01-06 Thread Woodhouse, David
On Fri, 2018-01-05 at 18:12 -0800, Tim Chen wrote: > On new microcode write, check whether IBRS > is present by rescanning IBRS feature. > > Signed-off-by: Tim Chen Didn't we also give you a patch which fixed up the error handling on the microcode reload, when it fails on only one CPU?

[PATCH v2 6/8] x86/microcode: Recheck IBRS features on microcode reload

2018-01-05 Thread Tim Chen
On new microcode write, check whether IBRS is present by rescanning IBRS feature. Signed-off-by: Tim Chen --- arch/x86/include/asm/spec_ctrl.h | 1 + arch/x86/kernel/cpu/microcode/core.c | 4 arch/x86/kernel/cpu/spec_ctrl.c | 18 ++ 3

[PATCH v2 6/8] x86/microcode: Recheck IBRS features on microcode reload

2018-01-05 Thread Tim Chen
On new microcode write, check whether IBRS is present by rescanning IBRS feature. Signed-off-by: Tim Chen --- arch/x86/include/asm/spec_ctrl.h | 1 + arch/x86/kernel/cpu/microcode/core.c | 4 arch/x86/kernel/cpu/spec_ctrl.c | 18 ++ 3 files changed, 15