Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

2019-06-27 Thread Alexandre Belloni
On 27/06/2019 15:34:40+0200, Wolfram Sang wrote: > > > > Apart from enabling the filter there is indeed one configuration > > > setting, the maximum pulse width of spikes to be suppressed by the input > > > filter. > > Yup, this is what I anticipated. > > > This is a number 0 to 7 (3 bits) that

Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

2019-06-27 Thread Wolfram Sang
> > Apart from enabling the filter there is indeed one configuration > > setting, the maximum pulse width of spikes to be suppressed by the input > > filter. Yup, this is what I anticipated. > This is a number 0 to 7 (3 bits) that represents the width of the spike > in periph clock cycles. For

Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

2019-06-27 Thread Eugen.Hristev
On 27.06.2019 16:22, Alexandre Belloni wrote: > External E-Mail > > > On 25/06/2019 11:55:33+0200, Wolfram Sang wrote: >> On Tue, Jun 25, 2019 at 11:31:56AM +0200, Alexandre Belloni wrote: >>> On 25/06/2019 09:14:13+, eugen.hris...@microchip.com wrote: > Perhaps > > microchip,

Re: I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

2019-06-27 Thread Alexandre Belloni
On 25/06/2019 11:55:33+0200, Wolfram Sang wrote: > On Tue, Jun 25, 2019 at 11:31:56AM +0200, Alexandre Belloni wrote: > > On 25/06/2019 09:14:13+, eugen.hris...@microchip.com wrote: > > > > Perhaps > > > > > > > > microchip,digital-filter; > > > > microchip,analog-filter; > > >

I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt)

2019-06-25 Thread Wolfram Sang
On Tue, Jun 25, 2019 at 11:31:56AM +0200, Alexandre Belloni wrote: > On 25/06/2019 09:14:13+, eugen.hris...@microchip.com wrote: > > > Perhaps > > > > > > microchip,digital-filter; > > > microchip,analog-filter; > > > > > > ? > > > > Hi Peter, > > > > Thanks for reviewing. The name of t

Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt

2019-06-25 Thread Alexandre Belloni
On 25/06/2019 09:14:13+, eugen.hris...@microchip.com wrote: > > Perhaps > > > > microchip,digital-filter; > > microchip,analog-filter; > > > > ? > > Hi Peter, > > Thanks for reviewing. The name of the property does not matter much to > me, and we have properties prefixed with vendo

Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt

2019-06-25 Thread Eugen.Hristev
On 25.06.2019 11:55, Peter Rosin wrote: > > On 2019-06-25 10:05, eugen.hris...@microchip.com wrote: >> From: Eugen Hristev >> >> Add binding specification for analogic filter inside the i2c controller > > s/analogic/the analog/ > >> Signed-off-by: Eugen Hristev >> --- >> Documentation/dev

Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt

2019-06-25 Thread Peter Rosin
On 2019-06-25 10:05, eugen.hris...@microchip.com wrote: > From: Eugen Hristev > > Add binding specification for analogic filter inside the i2c controller s/analogic/the analog/ > Signed-off-by: Eugen Hristev > --- > Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 > 1 file changed

[PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt

2019-06-25 Thread Eugen.Hristev
From: Eugen Hristev Add binding specification for analogic filter inside the i2c controller Signed-off-by: Eugen Hristev --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Document