Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-09-10 Thread Sergey Senozhatsky
On (09/10/19 01:59), Kees Cook wrote: > On Tue, Sep 10, 2019 at 01:05:39AM +0900, Sergey Senozhatsky wrote: > > On (08/20/19 09:47), Kees Cook wrote: > > [..] > > > + /* > > > + * BUG() and WARN_ON() families don't print a custom debug message > > > + * before triggering the exception handler,

Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-09-10 Thread Kees Cook
On Tue, Sep 10, 2019 at 01:05:39AM +0900, Sergey Senozhatsky wrote: > On (08/20/19 09:47), Kees Cook wrote: > [..] > > @@ -181,6 +181,15 @@ enum bug_trap_type report_bug(unsigned long bugaddr, > > struct pt_regs *regs) > > } > > } > > > > + /* > > +* BUG() and WARN_ON()

Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-09-09 Thread Sergey Senozhatsky
On (08/20/19 09:47), Kees Cook wrote: [..] > @@ -181,6 +181,15 @@ enum bug_trap_type report_bug(unsigned long bugaddr, > struct pt_regs *regs) > } > } > > + /* > + * BUG() and WARN_ON() families don't print a custom debug message > + * before triggering the

Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-29 Thread Kees Cook
On Thu, Aug 29, 2019 at 06:55:59AM +0200, Christophe Leroy wrote: > Euh ... only received this mail yesterday. Same for the other answer. Yeah, my outbound mail was busted. :( > I think you wanted to use In-reply-to: > [...] > But still, Andrew is seing double ... And me as well :) > > Fixes:

Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-28 Thread Christophe Leroy
-To: 20190819234111.9019-8-keesc...@chromium.org Really? That seems correct, that's the "[PATCH 7/7] bug: Move WARN_ON() "cut here" into exception handler" from the series at https://lkml.org/lkml/2019/8/19/1155 Subject: [PATCH v2 7/7] bug: Move WARN_ON() "cut her

Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-28 Thread Kees Cook
t; Really? > > That seems correct, that's the "[PATCH 7/7] bug: Move WARN_ON() "cut here" > into exception handler" from the series at > https://lkml.org/lkml/2019/8/19/1155 > > > > > > > Subject: [PATCH v2 7/7] bug: Move WARN_ON() "cut her

Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-23 Thread Christophe Leroy
In-Reply-To: 20190819234111.9019-8-keesc...@chromium.org Le 20/08/2019 à 18:47, Kees Cook a écrit : The original clean up of "cut here" missed the WARN_ON() case (that does not have a printk message), which was fixed recently by adding an explicit printk of "cut here". This had the downside of

Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-23 Thread Christophe Leroy
the series at https://lkml.org/lkml/2019/8/19/1155 Subject: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler It's strange to receive a standalone [7/7] patch. Iaw the Reply_To, I understand it as an update of the 7th patch of the series. Date: T

Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-22 Thread Andrew Morton
On Tue, 20 Aug 2019 09:47:55 -0700 Kees Cook wrote: > Reply-To: 20190819234111.9019-8-keesc...@chromium.org Really? > Subject: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler It's strange to receive a standalone [7/7] patch. > Date: Tue, 20 Aug

[PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler

2019-08-20 Thread Kees Cook
The original clean up of "cut here" missed the WARN_ON() case (that does not have a printk message), which was fixed recently by adding an explicit printk of "cut here". This had the downside of adding a printk() to every WARN_ON() caller, which reduces the utility of using an instruction