Re: [PATCH v2 7/9] test_sysctl: add simple proc_dointvec() case

2017-05-16 Thread Luis R. Rodriguez
On Mon, Feb 13, 2017 at 02:00:13PM -0800, Kees Cook wrote: > On Fri, Feb 10, 2017 at 4:36 PM, Luis R. Rodriguez wrote: > > diff --git a/tools/testing/selftests/sysctl/sysctl.sh > > b/tools/testing/selftests/sysctl/sysctl.sh > > index 14b9d875db42..45fd2ee5739c 100755 > > ---

Re: [PATCH v2 7/9] test_sysctl: add simple proc_dointvec() case

2017-05-16 Thread Luis R. Rodriguez
On Mon, Feb 13, 2017 at 02:00:13PM -0800, Kees Cook wrote: > On Fri, Feb 10, 2017 at 4:36 PM, Luis R. Rodriguez wrote: > > diff --git a/tools/testing/selftests/sysctl/sysctl.sh > > b/tools/testing/selftests/sysctl/sysctl.sh > > index 14b9d875db42..45fd2ee5739c 100755 > > ---

Re: [PATCH v2 7/9] test_sysctl: add simple proc_dointvec() case

2017-02-13 Thread Kees Cook
On Fri, Feb 10, 2017 at 4:36 PM, Luis R. Rodriguez wrote: > Test against a simple proc_dointvec() case. While at it, add > a test against INT_MAX. Make sure INT_MAX works, and INT_MAX+1 > will fail. Also test negative values work. > > Signed-off-by: Luis R. Rodriguez

Re: [PATCH v2 7/9] test_sysctl: add simple proc_dointvec() case

2017-02-13 Thread Kees Cook
On Fri, Feb 10, 2017 at 4:36 PM, Luis R. Rodriguez wrote: > Test against a simple proc_dointvec() case. While at it, add > a test against INT_MAX. Make sure INT_MAX works, and INT_MAX+1 > will fail. Also test negative values work. > > Signed-off-by: Luis R. Rodriguez > --- > lib/test_sysctl.c

[PATCH v2 7/9] test_sysctl: add simple proc_dointvec() case

2017-02-10 Thread Luis R. Rodriguez
Test against a simple proc_dointvec() case. While at it, add a test against INT_MAX. Make sure INT_MAX works, and INT_MAX+1 will fail. Also test negative values work. Signed-off-by: Luis R. Rodriguez --- lib/test_sysctl.c| 11 ++

[PATCH v2 7/9] test_sysctl: add simple proc_dointvec() case

2017-02-10 Thread Luis R. Rodriguez
Test against a simple proc_dointvec() case. While at it, add a test against INT_MAX. Make sure INT_MAX works, and INT_MAX+1 will fail. Also test negative values work. Signed-off-by: Luis R. Rodriguez --- lib/test_sysctl.c| 11 ++