Re: [PATCH v2 8/9] leds: add LM3633 driver

2015-11-30 Thread Jacek Anaszewski
On 11/30/2015 09:48 AM, Kim, Milo wrote: Hi Jacek, Thanks for your detailed feedback. Please refer to my comments below. On 11/27/2015 8:19 PM, Jacek Anaszewski wrote: Hi Milo, Thanks for the update. I have few comments below. diff --git a/drivers/leds/leds-lm3633.c

Re: [PATCH v2 8/9] leds: add LM3633 driver

2015-11-30 Thread Kim, Milo
Hi Jacek, Thanks for your detailed feedback. Please refer to my comments below. On 11/27/2015 8:19 PM, Jacek Anaszewski wrote: Hi Milo, Thanks for the update. I have few comments below. diff --git a/drivers/leds/leds-lm3633.c b/drivers/leds/leds-lm3633.c new file mode 100644 index

Re: [PATCH v2 8/9] leds: add LM3633 driver

2015-11-30 Thread Kim, Milo
Hi Jacek, Thanks for your detailed feedback. Please refer to my comments below. On 11/27/2015 8:19 PM, Jacek Anaszewski wrote: Hi Milo, Thanks for the update. I have few comments below. diff --git a/drivers/leds/leds-lm3633.c b/drivers/leds/leds-lm3633.c new file mode 100644 index

Re: [PATCH v2 8/9] leds: add LM3633 driver

2015-11-30 Thread Jacek Anaszewski
On 11/30/2015 09:48 AM, Kim, Milo wrote: Hi Jacek, Thanks for your detailed feedback. Please refer to my comments below. On 11/27/2015 8:19 PM, Jacek Anaszewski wrote: Hi Milo, Thanks for the update. I have few comments below. diff --git a/drivers/leds/leds-lm3633.c

Re: [PATCH v2 8/9] leds: add LM3633 driver

2015-11-28 Thread Jacek Anaszewski
On 11/27/2015 12:19 PM, Jacek Anaszewski wrote: Hi Milo, Thanks for the update. I have few comments below. [...] +static u8 lm3633_led_scale_max_brightness(struct ti_lmu_led *lmu_led, u32 imax) +{ +u8 max_current = lm3633_led_convert_current_to_index(imax); +const u8

Re: [PATCH v2 8/9] leds: add LM3633 driver

2015-11-28 Thread Jacek Anaszewski
On 11/27/2015 12:19 PM, Jacek Anaszewski wrote: Hi Milo, Thanks for the update. I have few comments below. [...] +static u8 lm3633_led_scale_max_brightness(struct ti_lmu_led *lmu_led, u32 imax) +{ +u8 max_current = lm3633_led_convert_current_to_index(imax); +const u8

Re: [PATCH v2 8/9] leds: add LM3633 driver

2015-11-27 Thread Jacek Anaszewski
Hi Milo, Thanks for the update. I have few comments below. On 11/26/2015 07:57 AM, Milo Kim wrote: LM3633 LED driver supports generic LED functions and pattern generation. Pattern is generated through the sysfs. ABI documentation is also added. Device creation from device tree

Re: [PATCH v2 8/9] leds: add LM3633 driver

2015-11-27 Thread Jacek Anaszewski
Hi Milo, Thanks for the update. I have few comments below. On 11/26/2015 07:57 AM, Milo Kim wrote: LM3633 LED driver supports generic LED functions and pattern generation. Pattern is generated through the sysfs. ABI documentation is also added. Device creation from device tree

[PATCH v2 8/9] leds: add LM3633 driver

2015-11-25 Thread Milo Kim
LM3633 LED driver supports generic LED functions and pattern generation. Pattern is generated through the sysfs. ABI documentation is also added. Device creation from device tree LED channel name, LED string usage and max current settings are configured inside

[PATCH v2 8/9] leds: add LM3633 driver

2015-11-25 Thread Milo Kim
LM3633 LED driver supports generic LED functions and pattern generation. Pattern is generated through the sysfs. ABI documentation is also added. Device creation from device tree LED channel name, LED string usage and max current settings are configured inside