Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-13 Thread Byungchul Park
On Mon, Feb 13, 2017 at 04:52:30PM +0100, Oleg Nesterov wrote: > On 02/13, Peter Zijlstra wrote: > > > > On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote: > > > + llist_for_each_entry(p, llist, wake_entry) > > > + ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED :

Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-13 Thread Byungchul Park
On Mon, Feb 13, 2017 at 04:52:30PM +0100, Oleg Nesterov wrote: > On 02/13, Peter Zijlstra wrote: > > > > On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote: > > > + llist_for_each_entry(p, llist, wake_entry) > > > + ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED :

Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-13 Thread Byungchul Park
On Mon, Feb 13, 2017 at 11:04:57AM +0100, Peter Zijlstra wrote: > On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote: > > Although llist provides proper APIs, they are not used. Make them used. > > > > Signed-off-by: Byungchul Park > > --- > >

Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-13 Thread Byungchul Park
On Mon, Feb 13, 2017 at 11:04:57AM +0100, Peter Zijlstra wrote: > On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote: > > Although llist provides proper APIs, they are not used. Make them used. > > > > Signed-off-by: Byungchul Park > > --- > > kernel/sched/core.c | 13 ++---

Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-13 Thread Oleg Nesterov
On 02/13, Peter Zijlstra wrote: > > On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote: > > + llist_for_each_entry(p, llist, wake_entry) > > + ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : > > 0, ); > > I think this suffers the exact same problem the

Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-13 Thread Oleg Nesterov
On 02/13, Peter Zijlstra wrote: > > On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote: > > + llist_for_each_entry(p, llist, wake_entry) > > + ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : > > 0, ); > > I think this suffers the exact same problem the

Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-13 Thread Peter Zijlstra
On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote: > Although llist provides proper APIs, they are not used. Make them used. > > Signed-off-by: Byungchul Park > --- > kernel/sched/core.c | 13 ++--- > 1 file changed, 2 insertions(+), 11 deletions(-)

Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-13 Thread Peter Zijlstra
On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote: > Although llist provides proper APIs, they are not used. Make them used. > > Signed-off-by: Byungchul Park > --- > kernel/sched/core.c | 13 ++--- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git

[PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-12 Thread Byungchul Park
Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park --- kernel/sched/core.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index

[PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API

2017-02-12 Thread Byungchul Park
Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park --- kernel/sched/core.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index d01f9d0..417060b 100644 ---