Re: [PATCH v2 linux-next] cpufreq: governors: Calculate iowait time only when necessary

2013-03-22 Thread Stratos Karafotis
On 03/22/2013 01:54 AM, Rafael J. Wysocki wrote: > > Applied to linux-pm.git/bleeding-edge and will be moved to linux-next if there > are no build problems in the bleeding-edge branch. > > Thanks, > Rafael Hi Rafael, I just noticed a regression with this patch with the calculation of wall time

Re: [PATCH v2 linux-next] cpufreq: governors: Calculate iowait time only when necessary

2013-03-22 Thread Stratos Karafotis
On 03/22/2013 01:54 AM, Rafael J. Wysocki wrote: Applied to linux-pm.git/bleeding-edge and will be moved to linux-next if there are no build problems in the bleeding-edge branch. Thanks, Rafael Hi Rafael, I just noticed a regression with this patch with the calculation of wall time in

Re: [PATCH v2 linux-next] cpufreq: governors: Calculate iowait time only when necessary

2013-03-21 Thread Rafael J. Wysocki
On Friday, March 01, 2013 09:18:08 AM Viresh Kumar wrote: > On 28 February 2013 22:27, Stratos Karafotis wrote: > > Currently we always calculate the CPU iowait time and add it to idle time. > > If we are in ondemand and we use io_is_busy, we re-calculate iowait time > > and we subtract it from

Re: [PATCH v2 linux-next] cpufreq: governors: Calculate iowait time only when necessary

2013-03-21 Thread Rafael J. Wysocki
On Friday, March 01, 2013 09:18:08 AM Viresh Kumar wrote: On 28 February 2013 22:27, Stratos Karafotis strat...@semaphore.gr wrote: Currently we always calculate the CPU iowait time and add it to idle time. If we are in ondemand and we use io_is_busy, we re-calculate iowait time and we

Re: [PATCH v2 linux-next] cpufreq: governors: Calculate iowait time only when necessary

2013-02-28 Thread Viresh Kumar
On 28 February 2013 22:27, Stratos Karafotis wrote: > Currently we always calculate the CPU iowait time and add it to idle time. > If we are in ondemand and we use io_is_busy, we re-calculate iowait time > and we subtract it from idle time. > > With this patch iowait time is calculated only when

Re: [PATCH v2 linux-next] cpufreq: governors: Calculate iowait time only when necessary

2013-02-28 Thread Stratos Karafotis
Hi Viresh, On 02/28/2013 08:58 AM, Viresh Kumar wrote: > I have really spent some 10-15 minutes reviewing this patch as initially it > looked to me like something is missing here and calculations are going wrong. > > But it was fine :) Thanks for you review. >> diff --git

Re: [PATCH v2 linux-next] cpufreq: governors: Calculate iowait time only when necessary

2013-02-28 Thread Stratos Karafotis
Hi Viresh, On 02/28/2013 08:58 AM, Viresh Kumar wrote: I have really spent some 10-15 minutes reviewing this patch as initially it looked to me like something is missing here and calculations are going wrong. But it was fine :) Thanks for you review. diff --git

Re: [PATCH v2 linux-next] cpufreq: governors: Calculate iowait time only when necessary

2013-02-28 Thread Viresh Kumar
On 28 February 2013 22:27, Stratos Karafotis strat...@semaphore.gr wrote: Currently we always calculate the CPU iowait time and add it to idle time. If we are in ondemand and we use io_is_busy, we re-calculate iowait time and we subtract it from idle time. With this patch iowait time is