Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-27 Thread David Miller
From: David Miller Date: Tue, 27 Aug 2019 20:20:43 -0700 (PDT) > Applied to net-next. My bad, applied to net and queued up for v5.2 -stable.

Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-27 Thread David Miller
From: Marco Hartmann Date: Wed, 21 Aug 2019 11:00:46 + > Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling > genphy_config_aneg") introduced a check that aborts phy_config_aneg() > if the phy is a C45 phy. > This causes phy_state_machine() to call phy_error() so tha

Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-27 Thread Andrew Lunn
On Tue, Aug 27, 2019 at 03:01:03PM -0700, David Miller wrote: > From: Marco Hartmann > Date: Wed, 21 Aug 2019 11:00:46 + > > > Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling > > genphy_config_aneg") introduced a check that aborts phy_config_aneg() > > if the phy

Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-27 Thread David Miller
From: Marco Hartmann Date: Wed, 21 Aug 2019 11:00:46 + > Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling > genphy_config_aneg") introduced a check that aborts phy_config_aneg() > if the phy is a C45 phy. > This causes phy_state_machine() to call phy_error() so tha

Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-22 Thread Heiner Kallweit
On 23.08.2019 01:15, David Miller wrote: > From: Marco Hartmann > Date: Wed, 21 Aug 2019 11:00:46 + > >> Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling >> genphy_config_aneg") introduced a check that aborts phy_config_aneg() >> if the phy is a C45 phy. >> This ca

Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-22 Thread David Miller
From: Marco Hartmann Date: Wed, 21 Aug 2019 11:00:46 + > Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling > genphy_config_aneg") introduced a check that aborts phy_config_aneg() > if the phy is a C45 phy. > This causes phy_state_machine() to call phy_error() so tha

Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-21 Thread Heiner Kallweit
On 21.08.2019 17:37, Andrew Lunn wrote: > On Wed, Aug 21, 2019 at 11:00:46AM +, Marco Hartmann wrote: >> Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling >> genphy_config_aneg") introduced a check that aborts phy_config_aneg() >> if the phy is a C45 phy. >> This caus

Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-21 Thread Andrew Lunn
On Wed, Aug 21, 2019 at 11:00:46AM +, Marco Hartmann wrote: > Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling > genphy_config_aneg") introduced a check that aborts phy_config_aneg() > if the phy is a C45 phy. > This causes phy_state_machine() to call phy_error() so

[PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-21 Thread Marco Hartmann
Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling genphy_config_aneg") introduced a check that aborts phy_config_aneg() if the phy is a C45 phy. This causes phy_state_machine() to call phy_error() so that the phy ends up in PHY_HALTED state. Instead of returning -EOPNOTS