Re: [PATCH v2 net] gtp: fix an use-before-init in gtp_newlink()

2020-10-26 Thread Jakub Kicinski
On Mon, 26 Oct 2020 16:22:27 +0900 Masahiro Fujiwara wrote: > v2: > - leave out_hashtable: label for clarity (Jakub). > - fix code and comment styles. Thanks! > diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c > index 8e47d0112e5d..07cb6d9495e8 100644 > --- a/drivers/net/gtp.c > +++

[PATCH v2 net] gtp: fix an use-before-init in gtp_newlink()

2020-10-26 Thread Masahiro Fujiwara
*_pdp_find() from gtp_encap_recv() would trigger a crash when a peer sends GTP packets while creating new GTP device. RIP: 0010:gtp1_pdp_find.isra.0+0x68/0x90 [gtp] Call Trace: gtp_encap_recv+0xc2/0x2e0 [gtp] ? gtp1_pdp_find.isra.0+0x90/0x90 [gtp] udp_queue_rcv_one_skb+0x1fe/0x530