Re: [PATCH v2.1 1/8] fsdax: introduce page->share for fsdax in reflink mode

2022-12-04 Thread Darrick J. Wong
On Mon, Dec 05, 2022 at 01:56:24PM +0800, Shiyang Ruan wrote: > > > 在 2022/12/3 10:07, Dan Williams 写道: > > Shiyang Ruan wrote: > > > fsdax page is used not only when CoW, but also mapread. To make the it > > > easily understood, use 'share' to indicate that the dax page is shared > > > by more

Re: [PATCH v2.1 1/8] fsdax: introduce page->share for fsdax in reflink mode

2022-12-04 Thread Shiyang Ruan
在 2022/12/3 10:07, Dan Williams 写道: Shiyang Ruan wrote: fsdax page is used not only when CoW, but also mapread. To make the it easily understood, use 'share' to indicate that the dax page is shared by more than one extent. And add helper functions to use it. Also, the flag needs to be

RE: [PATCH v2.1 1/8] fsdax: introduce page->share for fsdax in reflink mode

2022-12-02 Thread Dan Williams
Shiyang Ruan wrote: > fsdax page is used not only when CoW, but also mapread. To make the it > easily understood, use 'share' to indicate that the dax page is shared > by more than one extent. And add helper functions to use it. > > Also, the flag needs to be renamed to PAGE_MAPPING_DAX_SHARED.

Re: [PATCH v2.1 1/8] fsdax: introduce page->share for fsdax in reflink mode

2022-12-02 Thread Allison Henderson
On Fri, 2022-12-02 at 09:23 +, Shiyang Ruan wrote: > fsdax page is used not only when CoW, but also mapread. To make the > it > easily understood, use 'share' to indicate that the dax page is > shared > by more than one extent.  And add helper functions to use it. > > Also, the flag needs to

Re: [PATCH v2.1 1/8] fsdax: introduce page->share for fsdax in reflink mode

2022-12-02 Thread Andrew Morton
On Fri, 2 Dec 2022 09:23:11 + Shiyang Ruan wrote: > fsdax page is used not only when CoW, but also mapread. To make the it > easily understood, use 'share' to indicate that the dax page is shared > by more than one extent. And add helper functions to use it. > > Also, the flag needs to be

[PATCH v2.1 1/8] fsdax: introduce page->share for fsdax in reflink mode

2022-12-02 Thread Shiyang Ruan
fsdax page is used not only when CoW, but also mapread. To make the it easily understood, use 'share' to indicate that the dax page is shared by more than one extent. And add helper functions to use it. Also, the flag needs to be renamed to PAGE_MAPPING_DAX_SHARED. Signed-off-by: Shiyang Ruan