Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail

在 2020/11/3 上午12:03, Matthew Wilcox 写道: > On Fri, Oct 30, 2020 at 10:46:54AM +0800, Alex Shi wrote: >> -static void lru_add_page_tail(struct page *page, struct page *page_tail, >> +static void lru_add_page_tail(struct page *head, struct page *tail, >> struct lruvec *lruvec, struct l

Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail

On Fri, Oct 30, 2020 at 10:46:54AM +0800, Alex Shi wrote: > -static void lru_add_page_tail(struct page *page, struct page *page_tail, > +static void lru_add_page_tail(struct page *head, struct page *tail, > struct lruvec *lruvec, struct list_head *list) > { > - VM_BUG_ON_PAGE(!Pa

Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail

在 2020/10/30 下午9:52, Johannes Weiner 写道: > >> From a9ee63a213f40eb4d5a69b52fbb348ff9cd7cf6c Mon Sep 17 00:00:00 2001 >> From: Alex Shi >> Date: Tue, 26 May 2020 16:49:22 +0800 >> Subject: [PATCH v21 04/20] mm/thp: use head for head page in >> lru_add_page_tail >> >> Since the first parameter

Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail

On Fri, Oct 30, 2020 at 10:46:54AM +0800, Alex Shi wrote: > 在 2020/10/29 下午9:50, Johannes Weiner 写道: > > It may be better to pick either > > head and tail > > Hi Johannes, > > Thanks for comments! > > Right, Consider functions in this file are using head/tail more as parameters > I will chan

Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail

在 2020/10/29 下午9:50, Johannes Weiner 写道: > On Thu, Oct 29, 2020 at 06:44:49PM +0800, Alex Shi wrote: >> Since the first parameter is only used by head page, it's better to make >> it explicit. >> >> Signed-off-by: Alex Shi >> Reviewed-by: Kirill A. Shutemov >> Acked-by: Hugh Dickins >> Cc: An

Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail

On Thu, Oct 29, 2020 at 06:44:49PM +0800, Alex Shi wrote: > Since the first parameter is only used by head page, it's better to make > it explicit. > > Signed-off-by: Alex Shi > Reviewed-by: Kirill A. Shutemov > Acked-by: Hugh Dickins > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Matthew Wi

[PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail

Since the first parameter is only used by head page, it's better to make it explicit. Signed-off-by: Alex Shi Reviewed-by: Kirill A. Shutemov Acked-by: Hugh Dickins Cc: Andrew Morton Cc: Johannes Weiner Cc: Matthew Wilcox Cc: Hugh Dickins Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.