Re: [PATCH v21 07/19] mm: page_idle_get_page() does not need lru_lock

2020-11-11 Thread Vlastimil Babka
On 11/11/20 9:17 AM, huang ying wrote: On Thu, Nov 5, 2020 at 4:56 PM Alex Shi wrote: From: Hugh Dickins It is necessary for page_idle_get_page() to recheck PageLRU() after get_page_unless_zero(), but holding lru_lock around that serves no useful purpose, and adds to lru_lock contention: del

Re: [PATCH v21 07/19] mm: page_idle_get_page() does not need lru_lock

2020-11-11 Thread huang ying
On Thu, Nov 5, 2020 at 4:56 PM Alex Shi wrote: > > From: Hugh Dickins > > It is necessary for page_idle_get_page() to recheck PageLRU() after > get_page_unless_zero(), but holding lru_lock around that serves no > useful purpose, and adds to lru_lock contention: delete it. > > See https://lore.ker

Re: [PATCH v21 07/19] mm: page_idle_get_page() does not need lru_lock

2020-11-10 Thread Johannes Weiner
On Thu, Nov 05, 2020 at 04:55:37PM +0800, Alex Shi wrote: > From: Hugh Dickins > > It is necessary for page_idle_get_page() to recheck PageLRU() after > get_page_unless_zero(), but holding lru_lock around that serves no > useful purpose, and adds to lru_lock contention: delete it. > > See https:

[PATCH v21 07/19] mm: page_idle_get_page() does not need lru_lock

2020-11-05 Thread Alex Shi
From: Hugh Dickins It is necessary for page_idle_get_page() to recheck PageLRU() after get_page_unless_zero(), but holding lru_lock around that serves no useful purpose, and adds to lru_lock contention: delete it. See https://lore.kernel.org/lkml/20150504031722.GA2768@blaptop for the discussion