Re: [PATCH v21 24/28] selftests/x86: Add a selftest for SGX

2019-08-16 Thread Jarkko Sakkinen
On Wed, Jul 17, 2019 at 03:37:03PM -0700, Xing, Cedric wrote: > > +$(TEST_CUSTOM_PROGS): $(OUTPUT)/main.o $(OUTPUT)/sgx_call.o \ > > + $(OUTPUT)/encl_piggy.o > > + $(CC) $(HOST_CFLAGS) -o $@ $^ > > + > > +$(OUTPUT)/main.o: main.c > > + $(CC) $(HOST_CFLAGS) -c $< -o $@ > > .o

Re: [PATCH v21 24/28] selftests/x86: Add a selftest for SGX

2019-08-16 Thread Jarkko Sakkinen
On Fri, Aug 16, 2019 at 06:43:44PM +0300, Jarkko Sakkinen wrote: > On Wed, Jul 17, 2019 at 03:37:03PM -0700, Xing, Cedric wrote: > > > +$(OUTPUT)/encl.bin: $(OUTPUT)/encl.elf $(OUTPUT)/sgxsign > > > + objcopy --remove-section=.got.plt -O binary $< $@ > > > > .got.plt section will never be present

Re: [PATCH v21 24/28] selftests/x86: Add a selftest for SGX

2019-08-16 Thread Jarkko Sakkinen
On Wed, Jul 17, 2019 at 03:37:03PM -0700, Xing, Cedric wrote: > > +$(OUTPUT)/encl.bin: $(OUTPUT)/encl.elf $(OUTPUT)/sgxsign > > + objcopy --remove-section=.got.plt -O binary $< $@ > > .got.plt section will never be present for statically linked binaries. You are right that it should not be

Re: [PATCH v21 24/28] selftests/x86: Add a selftest for SGX

2019-08-02 Thread Jarkko Sakkinen
On Wed, Jul 17, 2019 at 03:37:03PM -0700, Xing, Cedric wrote: > On 7/13/2019 10:08 AM, Jarkko Sakkinen wrote: > > Add a selftest for SGX. It is a trivial test where a simple enclave > > copies one 64-bit word of memory between two memory locations given to > > the enclave as arguments. > > > >

Re: [PATCH v21 24/28] selftests/x86: Add a selftest for SGX

2019-07-17 Thread Xing, Cedric
On 7/13/2019 10:08 AM, Jarkko Sakkinen wrote: Add a selftest for SGX. It is a trivial test where a simple enclave copies one 64-bit word of memory between two memory locations given to the enclave as arguments. Signed-off-by: Jarkko Sakkinen --- tools/testing/selftests/x86/Makefile

[PATCH v21 24/28] selftests/x86: Add a selftest for SGX

2019-07-13 Thread Jarkko Sakkinen
Add a selftest for SGX. It is a trivial test where a simple enclave copies one 64-bit word of memory between two memory locations given to the enclave as arguments. Signed-off-by: Jarkko Sakkinen --- tools/testing/selftests/x86/Makefile | 10 + tools/testing/selftests/x86/sgx/Makefile