Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-12-18 Thread Dmitry Torokhov
On Wed, Oct 28, 2015 at 11:10:06AM -0400, Benjamin Tissoires wrote: > Hi, > > On Oct 25 2015 or thereabouts, David Herrmann wrote: > > Hi > > > > On Sun, Oct 25, 2015 at 12:53 AM, Dmitry Torokhov > > wrote: > > > Hi Benjamin, > > > > > > On Tue, Aug 25, 2015 at 11:12:59AM -0400, Benjamin Tissoir

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-11-10 Thread Elias Vanderstuyft
quot; >> , "open list:HID CORE LAYER" >> , linux-kernel@vger.kernel.org >> Sent: Sunday, November 8, 2015 11:55:04 AM >> Subject: Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and >> UI_ABS_SETUP ioctl >> >> I.e., why not: >> >>

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-11-08 Thread Benjamin Tissoires
g > Sent: Sunday, November 8, 2015 11:55:04 AM > Subject: Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and > UI_ABS_SETUP ioctl > > Hi, > > On Tue, Aug 25, 2015 at 5:12 PM, Benjamin Tissoires > wrote: > > diff --git a/include/uapi/linux/uinput.h b/i

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-11-08 Thread Elias Vanderstuyft
Hi, On Tue, Aug 25, 2015 at 5:12 PM, Benjamin Tissoires wrote: > diff --git a/include/uapi/linux/uinput.h b/include/uapi/linux/uinput.h > index 013c9d8..ef6c9f5 100644 > --- a/include/uapi/linux/uinput.h > +++ b/include/uapi/linux/uinput.h > @@ -20,6 +20,11 @@ > * Author: Aristeu Sergio Rozansk

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-10-28 Thread Benjamin Tissoires
Hi, On Oct 25 2015 or thereabouts, David Herrmann wrote: > Hi > > On Sun, Oct 25, 2015 at 12:53 AM, Dmitry Torokhov > wrote: > > Hi Benjamin, > > > > On Tue, Aug 25, 2015 at 11:12:59AM -0400, Benjamin Tissoires wrote: > >> +static int uinput_abs_setup(struct uinput_device *udev, > >> +

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-10-25 Thread David Herrmann
Hi On Sun, Oct 25, 2015 at 12:53 AM, Dmitry Torokhov wrote: > Hi Benjamin, > > On Tue, Aug 25, 2015 at 11:12:59AM -0400, Benjamin Tissoires wrote: >> +static int uinput_abs_setup(struct uinput_device *udev, >> + struct uinput_setup __user *arg, size_t size) >> +{ >> +

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-10-24 Thread Dmitry Torokhov
Hi Benjamin, On Tue, Aug 25, 2015 at 11:12:59AM -0400, Benjamin Tissoires wrote: > +static int uinput_abs_setup(struct uinput_device *udev, > + struct uinput_setup __user *arg, size_t size) > +{ > + struct uinput_abs_setup setup = {}; > + struct input_dev *dev; > +

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-10-19 Thread Benjamin Tissoires
Dmitry, ping again on this one :) any comments? Cheers, Benjamin On Mon, Sep 21, 2015 at 6:45 AM, David Herrmann wrote: > Hi Dmitry > > Any comment on this? > > Thanks > David > > On Tue, Aug 25, 2015 at 5:12 PM, Benjamin Tissoires > wrote: >> This adds two new ioctls, UINPUT_DEV_SETUP and UI

Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-09-21 Thread David Herrmann
Hi Dmitry Any comment on this? Thanks David On Tue, Aug 25, 2015 at 5:12 PM, Benjamin Tissoires wrote: > This adds two new ioctls, UINPUT_DEV_SETUP and UI_ABS_SETUP, that > replaces the old device setup method (by write()'ing "struct > uinput_user_dev" to the node). The old method is not easily

[PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl

2015-08-25 Thread Benjamin Tissoires
This adds two new ioctls, UINPUT_DEV_SETUP and UI_ABS_SETUP, that replaces the old device setup method (by write()'ing "struct uinput_user_dev" to the node). The old method is not easily extendable and requires huge payloads. Furthermore, overloading write() without properly versioned objects is er