Re: [PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-27 Thread Paolo Bonzini
On 27/02/2018 03:22, Wanpeng Li wrote: >>> @@ -2551,7 +2561,7 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct >>> msr_data *msr_info) >>> msr_info->data = 0; >>> break; >>> case MSR_IA32_UCODE_REV: >>> - msr_info->data = 0x1ULL; >>> +

Re: [PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-27 Thread Paolo Bonzini
On 27/02/2018 03:22, Wanpeng Li wrote: >>> @@ -2551,7 +2561,7 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct >>> msr_data *msr_info) >>> msr_info->data = 0; >>> break; >>> case MSR_IA32_UCODE_REV: >>> - msr_info->data = 0x1ULL; >>> +

Re: [PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-26 Thread Nadav Amit
Wanpeng Li wrote: > 2018-02-27 9:30 GMT+08:00 Nadav Amit : >> Wanpeng Li wrote: >> >>> From: Wanpeng Li >>> >>> Linux (among the others) has checks to make sure that certain features >>> aren't enabled on

Re: [PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-26 Thread Nadav Amit
Wanpeng Li wrote: > 2018-02-27 9:30 GMT+08:00 Nadav Amit : >> Wanpeng Li wrote: >> >>> From: Wanpeng Li >>> >>> Linux (among the others) has checks to make sure that certain features >>> aren't enabled on a certain family/model/stepping if the microcode version >>> isn't greater than or

Re: [PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-26 Thread Wanpeng Li
2018-02-27 9:30 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> From: Wanpeng Li >> >> Linux (among the others) has checks to make sure that certain features >> aren't enabled on a certain family/model/stepping if the microcode

Re: [PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-26 Thread Wanpeng Li
2018-02-27 9:30 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> From: Wanpeng Li >> >> Linux (among the others) has checks to make sure that certain features >> aren't enabled on a certain family/model/stepping if the microcode version >> isn't greater than or equal to a known good version. >>

Re: [PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-26 Thread Nadav Amit
Wanpeng Li wrote: > From: Wanpeng Li > > Linux (among the others) has checks to make sure that certain features > aren't enabled on a certain family/model/stepping if the microcode version > isn't greater than or equal to a known good version. > >

Re: [PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-26 Thread Nadav Amit
Wanpeng Li wrote: > From: Wanpeng Li > > Linux (among the others) has checks to make sure that certain features > aren't enabled on a certain family/model/stepping if the microcode version > isn't greater than or equal to a known good version. > > By exposing the real microcode version,

[PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-26 Thread Wanpeng Li
From: Wanpeng Li Linux (among the others) has checks to make sure that certain features aren't enabled on a certain family/model/stepping if the microcode version isn't greater than or equal to a known good version. By exposing the real microcode version, we're

[PATCH v3] KVM: X86: Allow userspace to define the microcode version

2018-02-26 Thread Wanpeng Li
From: Wanpeng Li Linux (among the others) has checks to make sure that certain features aren't enabled on a certain family/model/stepping if the microcode version isn't greater than or equal to a known good version. By exposing the real microcode version, we're preventing buggy guests that