RE: [PATCH v3] PCI: Introduce flag for detached virtual functions

2020-09-01 Thread Tian, Kevin
> From: kvm-ow...@vger.kernel.org On Behalf > Of Niklas Schnelle > Sent: Friday, August 28, 2020 5:10 PM > To: Bjorn Helgaas ; Alex Williamson > > [...] > >> > >> FWIW, pci_physfn() never returns NULL, it returns the provided pdev if > >> is_virtfn is not set. This proposal wouldn't change

Re: [PATCH v3] PCI: Introduce flag for detached virtual functions

2020-08-28 Thread Niklas Schnelle
On 8/27/20 10:33 PM, Bjorn Helgaas wrote: > On Thu, Aug 27, 2020 at 01:17:48PM -0600, Alex Williamson wrote: >> On Thu, 27 Aug 2020 13:31:38 -0500 >> Bjorn Helgaas wrote: >> >>> Re the subject line, this patch does a lot more than just "introduce a >>> flag"; AFAICT it actually enables important

Re: [PATCH v3] PCI: Introduce flag for detached virtual functions

2020-08-27 Thread Bjorn Helgaas
On Thu, Aug 27, 2020 at 01:17:48PM -0600, Alex Williamson wrote: > On Thu, 27 Aug 2020 13:31:38 -0500 > Bjorn Helgaas wrote: > > > Re the subject line, this patch does a lot more than just "introduce a > > flag"; AFAICT it actually enables important VFIO functionality, e.g., > > something like:

Re: [PATCH v3] PCI: Introduce flag for detached virtual functions

2020-08-27 Thread Matthew Rosato
On 8/27/20 2:31 PM, Bjorn Helgaas wrote: Re the subject line, this patch does a lot more than just "introduce a flag"; AFAICT it actually enables important VFIO functionality, e.g., something like: vfio/pci: Enable MMIO access for s390 detached VFs Fair -- maybe s/Enable/Restore/ as this

Re: [PATCH v3] PCI: Introduce flag for detached virtual functions

2020-08-27 Thread Alex Williamson
On Thu, 27 Aug 2020 13:31:38 -0500 Bjorn Helgaas wrote: > Re the subject line, this patch does a lot more than just "introduce a > flag"; AFAICT it actually enables important VFIO functionality, e.g., > something like: > > vfio/pci: Enable MMIO access for s390 detached VFs > > On Thu, Aug

Re: [PATCH v3] PCI: Introduce flag for detached virtual functions

2020-08-27 Thread Bjorn Helgaas
Re the subject line, this patch does a lot more than just "introduce a flag"; AFAICT it actually enables important VFIO functionality, e.g., something like: vfio/pci: Enable MMIO access for s390 detached VFs On Thu, Aug 13, 2020 at 11:40:43AM -0400, Matthew Rosato wrote: > s390x has the notion

Re: [PATCH v3] PCI: Introduce flag for detached virtual functions

2020-08-25 Thread Alex Williamson
On Mon, 24 Aug 2020 10:21:24 -0400 Matthew Rosato wrote: > On 8/13/20 11:40 AM, Matthew Rosato wrote: > > s390x has the notion of providing VFs to the kernel in a manner > > where the associated PF is inaccessible other than via firmware. > > These are not treated as typical VFs and access to

Re: [PATCH v3] PCI: Introduce flag for detached virtual functions

2020-08-24 Thread Matthew Rosato
On 8/13/20 11:40 AM, Matthew Rosato wrote: s390x has the notion of providing VFs to the kernel in a manner where the associated PF is inaccessible other than via firmware. These are not treated as typical VFs and access to them is emulated by underlying firmware which can still access the PF.

[PATCH v3] PCI: Introduce flag for detached virtual functions

2020-08-13 Thread Matthew Rosato
s390x has the notion of providing VFs to the kernel in a manner where the associated PF is inaccessible other than via firmware. These are not treated as typical VFs and access to them is emulated by underlying firmware which can still access the PF. After the referened commit however these