Re: [PATCH v3] cgroup: Add pids controller event when fork fails because of pid limit

Thanks for the feedback Tejun! On 6/21/16, 1:12 PM, "Tejun Heo" wrote: >Hello, > >Just a couple nits. > >On Tue, Jun 21, 2016 at 09:56:38AM -0700, Kenny Yu wrote: >> Summary: > >No need for "Summary:" tag. > >> This patch adds more visibility into

Re: [PATCH v3] cgroup: Add pids controller event when fork fails because of pid limit

Thanks for the feedback Tejun! On 6/21/16, 1:12 PM, "Tejun Heo" wrote: >Hello, > >Just a couple nits. > >On Tue, Jun 21, 2016 at 09:56:38AM -0700, Kenny Yu wrote: >> Summary: > >No need for "Summary:" tag. > >> This patch adds more visibility into the pids controller when the controller >>

Re: [PATCH v3] cgroup: Add pids controller event when fork fails because of pid limit

Hello, On Tue, Jun 21, 2016 at 05:23:40PM +, Kenny Yu wrote: > >It'd be better to use atomic64_inc_and_test() instead. > > > > if (err) { > > if (atomic64_inc_and_test()) { > > pr_xxx...; > > } > > cgroup_file_notify(>events_file); >

Re: [PATCH v3] cgroup: Add pids controller event when fork fails because of pid limit

Hello, On Tue, Jun 21, 2016 at 05:23:40PM +, Kenny Yu wrote: > >It'd be better to use atomic64_inc_and_test() instead. > > > > if (err) { > > if (atomic64_inc_and_test()) { > > pr_xxx...; > > } > > cgroup_file_notify(>events_file); >

Re: [PATCH v3] cgroup: Add pids controller event when fork fails because of pid limit

Hello, Just a couple nits. On Tue, Jun 21, 2016 at 09:56:38AM -0700, Kenny Yu wrote: > Summary: No need for "Summary:" tag. > This patch adds more visibility into the pids controller when the controller > rejects a fork request. Whenever fork fails because the limit on the number of > pids in

Re: [PATCH v3] cgroup: Add pids controller event when fork fails because of pid limit

Hello, Just a couple nits. On Tue, Jun 21, 2016 at 09:56:38AM -0700, Kenny Yu wrote: > Summary: No need for "Summary:" tag. > This patch adds more visibility into the pids controller when the controller > rejects a fork request. Whenever fork fails because the limit on the number of > pids in

[PATCH v3] cgroup: Add pids controller event when fork fails because of pid limit

Summary: This patch adds more visibility into the pids controller when the controller rejects a fork request. Whenever fork fails because the limit on the number of pids in the cgroup is reached, the controller will log this and also notify the newly added cgroups events file. The `max` key in the

[PATCH v3] cgroup: Add pids controller event when fork fails because of pid limit

Summary: This patch adds more visibility into the pids controller when the controller rejects a fork request. Whenever fork fails because the limit on the number of pids in the cgroup is reached, the controller will log this and also notify the newly added cgroups events file. The `max` key in the