Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-25 Thread Philippe CORNU
Hi, in short: this patch is "CANCELLED" : ) Thanks to comments from some of you, I managed to use adjusted_mode. Please have a look to the patch "drm/bridge/synopsys: dsi: use adjusted_mode in mode_set". Hope it is better, comments are welcome Many thanks, Philippe :-) On 01/23/2018 06:08

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-25 Thread Philippe CORNU
Hi, in short: this patch is "CANCELLED" : ) Thanks to comments from some of you, I managed to use adjusted_mode. Please have a look to the patch "drm/bridge/synopsys: dsi: use adjusted_mode in mode_set". Hope it is better, comments are welcome Many thanks, Philippe :-) On 01/23/2018 06:08

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-25 Thread Philippe CORNU
Hi Brian, On 01/24/2018 07:09 PM, Brian Norris wrote: > On Wed, Jan 24, 2018 at 09:24:06AM +, Philippe CORNU wrote: >> On 01/23/2018 09:49 PM, Brian Norris wrote: >>> On Tue, Jan 23, 2018 at 06:08:06PM +0100, Philippe Cornu wrote: --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-25 Thread Philippe CORNU
Hi Brian, On 01/24/2018 07:09 PM, Brian Norris wrote: > On Wed, Jan 24, 2018 at 09:24:06AM +, Philippe CORNU wrote: >> On 01/23/2018 09:49 PM, Brian Norris wrote: >>> On Tue, Jan 23, 2018 at 06:08:06PM +0100, Philippe Cornu wrote: --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-24 Thread Brian Norris
On Wed, Jan 24, 2018 at 09:24:06AM +, Philippe CORNU wrote: > On 01/23/2018 09:49 PM, Brian Norris wrote: > > On Tue, Jan 23, 2018 at 06:08:06PM +0100, Philippe Cornu wrote: > >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >>

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-24 Thread Brian Norris
On Wed, Jan 24, 2018 at 09:24:06AM +, Philippe CORNU wrote: > On 01/23/2018 09:49 PM, Brian Norris wrote: > > On Tue, Jan 23, 2018 at 06:08:06PM +0100, Philippe Cornu wrote: > >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > >>

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-24 Thread Philippe CORNU
Hi Brian, On 01/23/2018 09:49 PM, Brian Norris wrote: > Hi, > > Philippe asked me to review the last version. I'm not sure I have a lot > to contribute. Maybe Rockchip folks who wrote this stuff in the first > place might. I've CC'd some. > > On Tue, Jan 23, 2018 at 06:08:06PM +0100, Philippe

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-24 Thread Philippe CORNU
Hi Brian, On 01/23/2018 09:49 PM, Brian Norris wrote: > Hi, > > Philippe asked me to review the last version. I'm not sure I have a lot > to contribute. Maybe Rockchip folks who wrote this stuff in the first > place might. I've CC'd some. > > On Tue, Jan 23, 2018 at 06:08:06PM +0100, Philippe

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-23 Thread Brian Norris
Hi, Philippe asked me to review the last version. I'm not sure I have a lot to contribute. Maybe Rockchip folks who wrote this stuff in the first place might. I've CC'd some. On Tue, Jan 23, 2018 at 06:08:06PM +0100, Philippe Cornu wrote: > The pixel clock is optional. When available, it offers

Re: [PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-23 Thread Brian Norris
Hi, Philippe asked me to review the last version. I'm not sure I have a lot to contribute. Maybe Rockchip folks who wrote this stuff in the first place might. I've CC'd some. On Tue, Jan 23, 2018 at 06:08:06PM +0100, Philippe Cornu wrote: > The pixel clock is optional. When available, it offers

[PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-23 Thread Philippe Cornu
The pixel clock is optional. When available, it offers a better preciseness for timing computations and allows to reduce the extra dsi bandwidth in burst mode (from ~20% to ~10-12%, hw platform dependant). Reviewed-by: Andrzej Hajda Signed-off-by: Philippe Cornu

[PATCH v3] drm/bridge/synopsys: dsi: add optional pixel clock

2018-01-23 Thread Philippe Cornu
The pixel clock is optional. When available, it offers a better preciseness for timing computations and allows to reduce the extra dsi bandwidth in burst mode (from ~20% to ~10-12%, hw platform dependant). Reviewed-by: Andrzej Hajda Signed-off-by: Philippe Cornu --- Changes in v3: Simplify