Re: [PATCH v3] drm/i915/skl: Don't try to update plane watermarks if they haven't changed

2016-09-02 Thread Lyude
Since this patch has been on hold for a little bit, I did a bit of thinking of how we could this a little more cleanly. Unfortunately I couldn't think of a way, however I did think of an alternative solution: I'm planning on backporting all of the skl wm fixes already, so I'm going to use this

Re: [PATCH v3] drm/i915/skl: Don't try to update plane watermarks if they haven't changed

2016-09-02 Thread Lyude
Since this patch has been on hold for a little bit, I did a bit of thinking of how we could this a little more cleanly. Unfortunately I couldn't think of a way, however I did think of an alternative solution: I'm planning on backporting all of the skl wm fixes already, so I'm going to use this

[PATCH v3] drm/i915/skl: Don't try to update plane watermarks if they haven't changed

2016-08-29 Thread Lyude
i915 sometimes needs to disable planes in the middle of an atomic commit, and then reenable them later in the same commit. Because of this, we can't make the assumption that the state of the plane actually changed. Since the state of the plane hasn't actually changed, neither have it's watermarks.

[PATCH v3] drm/i915/skl: Don't try to update plane watermarks if they haven't changed

2016-08-29 Thread Lyude
i915 sometimes needs to disable planes in the middle of an atomic commit, and then reenable them later in the same commit. Because of this, we can't make the assumption that the state of the plane actually changed. Since the state of the plane hasn't actually changed, neither have it's watermarks.