Re: [PATCH v3] ext4: Fix ext4_error_err save negative errno into superblock

2021-04-09 Thread Theodore Ts'o
On Tue, Apr 06, 2021 at 10:53:31AM +0800, Ye Bin wrote: > As write_mmp_block return 1 when buffer isn't uptodate, return -EIO is > more appropriate. > > Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop > ext4_set_errno()") > Reported-by: Liu Zhi Qiang > Signed-off-by

[PATCH v3] ext4: Fix ext4_error_err save negative errno into superblock

2021-04-05 Thread Ye Bin
As write_mmp_block return 1 when buffer isn't uptodate, return -EIO is more appropriate. Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()") Reported-by: Liu Zhi Qiang Signed-off-by: Ye Bin Reviewed-by: Andreas Dilger --- fs/ext4/mmp.c | 2 +- 1 fi