Re: [PATCH v3] gpio: winbond: add driver

2018-01-04 Thread Maciej S. Szmigiero
On 04.01.2018 18:35, Andy Shevchenko wrote: > On Thu, 2018-01-04 at 00:41 +0100, Maciej S. Szmigiero wrote: >> On 03.01.2018 20:05, Andy Shevchenko wrote: >>> On Sat, 2017-12-30 at 22:02 +0100, Maciej S. Szmigiero wrote: This commit adds GPIO driver for Winbond Super I/Os. > >>> First of

Re: [PATCH v3] gpio: winbond: add driver

2018-01-04 Thread Maciej S. Szmigiero
On 04.01.2018 18:35, Andy Shevchenko wrote: > On Thu, 2018-01-04 at 00:41 +0100, Maciej S. Szmigiero wrote: >> On 03.01.2018 20:05, Andy Shevchenko wrote: >>> On Sat, 2017-12-30 at 22:02 +0100, Maciej S. Szmigiero wrote: This commit adds GPIO driver for Winbond Super I/Os. > >>> First of

Re: [PATCH v3] gpio: winbond: add driver

2018-01-04 Thread Andy Shevchenko
On Thu, 2018-01-04 at 00:41 +0100, Maciej S. Szmigiero wrote: > On 03.01.2018 20:05, Andy Shevchenko wrote: > > On Sat, 2017-12-30 at 22:02 +0100, Maciej S. Szmigiero wrote: > > > This commit adds GPIO driver for Winbond Super I/Os. > > First of all, looking more at this driver, why don't we

Re: [PATCH v3] gpio: winbond: add driver

2018-01-04 Thread Andy Shevchenko
On Thu, 2018-01-04 at 00:41 +0100, Maciej S. Szmigiero wrote: > On 03.01.2018 20:05, Andy Shevchenko wrote: > > On Sat, 2017-12-30 at 22:02 +0100, Maciej S. Szmigiero wrote: > > > This commit adds GPIO driver for Winbond Super I/Os. > > First of all, looking more at this driver, why don't we

Re: [PATCH v3] gpio: winbond: add driver

2018-01-03 Thread Maciej S. Szmigiero
On 03.01.2018 20:05, Andy Shevchenko wrote: > On Sat, 2017-12-30 at 22:02 +0100, Maciej S. Szmigiero wrote: >> This commit adds GPIO driver for Winbond Super I/Os. >> >> Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is >> supported but in the future a support for other Winbond

Re: [PATCH v3] gpio: winbond: add driver

2018-01-03 Thread Maciej S. Szmigiero
On 03.01.2018 20:05, Andy Shevchenko wrote: > On Sat, 2017-12-30 at 22:02 +0100, Maciej S. Szmigiero wrote: >> This commit adds GPIO driver for Winbond Super I/Os. >> >> Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is >> supported but in the future a support for other Winbond

Re: [PATCH v3] gpio: winbond: add driver

2018-01-03 Thread Andy Shevchenko
On Sat, 2017-12-30 at 22:02 +0100, Maciej S. Szmigiero wrote: > This commit adds GPIO driver for Winbond Super I/Os. > > Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is > supported but in the future a support for other Winbond models, too, > can > be added to the driver. > >

Re: [PATCH v3] gpio: winbond: add driver

2018-01-03 Thread Andy Shevchenko
On Sat, 2017-12-30 at 22:02 +0100, Maciej S. Szmigiero wrote: > This commit adds GPIO driver for Winbond Super I/Os. > > Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is > supported but in the future a support for other Winbond models, too, > can > be added to the driver. > >

Re: [PATCH v3] gpio: winbond: add driver

2018-01-02 Thread kbuild test robot
Hi Maciej, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.15-rc6 next-20180102] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3] gpio: winbond: add driver

2018-01-02 Thread kbuild test robot
Hi Maciej, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on v4.15-rc6 next-20180102] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v3] gpio: winbond: add driver

2017-12-30 Thread Maciej S. Szmigiero
This commit adds GPIO driver for Winbond Super I/Os. Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is supported but in the future a support for other Winbond models, too, can be added to the driver. A module parameter "gpios" sets a bitmask of GPIO ports to enable (bit 0 is

[PATCH v3] gpio: winbond: add driver

2017-12-30 Thread Maciej S. Szmigiero
This commit adds GPIO driver for Winbond Super I/Os. Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is supported but in the future a support for other Winbond models, too, can be added to the driver. A module parameter "gpios" sets a bitmask of GPIO ports to enable (bit 0 is