Re: [PATCH v3] kdb: kdb_support: Fix debugging information problem

2021-02-03 Thread Doug Anderson
Hi, On Wed, Feb 3, 2021 at 3:31 AM Stephen Zhang wrote: > > Doug Anderson 于2021年2月3日周三 上午1:40写道: >> >> kdb_dbg_printf(AR, "returns [...] (%s)\n", >>ret, symtab->sym_start, [...], symtab->sym_name); > > > Thank you for the detailed explanation. In this case, Shouldn't the "ret" be >

Re: [PATCH v3] kdb: kdb_support: Fix debugging information problem

2021-02-02 Thread Doug Anderson
Hi, On Tue, Feb 2, 2021 at 3:15 AM Stephen Zhang wrote: >> >> >> > @@ -147,11 +141,10 @@ int kdbnearsym(unsigned long addr, kdb_symtab_t >> > *symtab) >> > >> > if (symtab->mod_name == NULL) >> > symtab->mod_name = "kernel"; >> > - if (KDB_DEBUG(AR)) >> > -

Re: [PATCH v3] kdb: kdb_support: Fix debugging information problem

2021-02-01 Thread Doug Anderson
Hi, On Sat, Jan 30, 2021 at 3:24 AM Stephen Zhang wrote: > > int kdbgetsymval(const char *symname, kdb_symtab_t *symtab) > { > - if (KDB_DEBUG(AR)) > - kdb_printf("kdbgetsymval: symname=%s, symtab=%px\n", symname, > - symtab); > +

[PATCH v3] kdb: kdb_support: Fix debugging information problem

2021-01-30 Thread Stephen Zhang
There are several common patterns. 0: kdb_printf("...",...); which is the normal one. 1: kdb_printf("%s: "...,__func__,...) We could improve '1' to this : #define kdb_func_printf(format, args...) \ kdb_printf("%s: " format, __func__, ## args) 2: