Re: [PATCH v3] lib/string: Introduce sysfs_streqcase

Hi Gioh, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on kees/for-next/pstore linus/master v5.12-rc6 next-20210408] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH v3] lib/string: Introduce sysfs_streqcase

Hi Jinpu, I removed #ifdef CONFIG_SYSFS ~ #endif. Could you please review again? On Thu, Apr 8, 2021 at 12:50 PM Jinpu Wang wrote: > > On Thu, Apr 8, 2021 at 11:34 AM Gioh Kim wrote: > > > > As the name shows, it checks if strings are equal in case insensitive > > manner. > > > > For example,

Re: [PATCH v3] lib/string: Introduce sysfs_streqcase

Hi Gioh, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on kees/for-next/pstore linus/master v5.12-rc6 next-20210407] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH v3] lib/string: Introduce sysfs_streqcase

On Thu, Apr 8, 2021 at 11:34 AM Gioh Kim wrote: > > As the name shows, it checks if strings are equal in case insensitive > manner. > > For example, drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c uses > strncasecmp to check that the input via sysfs is "mi". But it would > work even-if the input is

[PATCH v3] lib/string: Introduce sysfs_streqcase

As the name shows, it checks if strings are equal in case insensitive manner. For example, drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c uses strncasecmp to check that the input via sysfs is "mi". But it would work even-if the input is "min-wrongcommand". I found some more cases using strncasecmp