Re: [PATCH v3] libata: Use per port sync for detach

2020-06-18 Thread Jens Axboe
On 6/3/20 1:48 AM, Kai-Heng Feng wrote: > Commit 130f4caf145c ("libata: Ensure ata_port probe has completed before > detach") may cause system freeze during suspend. > > Using async_synchronize_full() in PM callbacks is wrong, since async > callbacks that are already scheduled may wait for

Re: [PATCH v3] libata: Use per port sync for detach

2020-06-17 Thread Kai-Heng Feng
Hi Jens, > On Jun 3, 2020, at 16:40, John Garry wrote: > > On 03/06/2020 08:48, Kai-Heng Feng wrote: >> Commit 130f4caf145c ("libata: Ensure ata_port probe has completed before >> detach") may cause system freeze during suspend. >> Using async_synchronize_full() in PM callbacks is wrong, since

Re: [PATCH v3] libata: Use per port sync for detach

2020-06-03 Thread John Garry
On 03/06/2020 08:48, Kai-Heng Feng wrote: Commit 130f4caf145c ("libata: Ensure ata_port probe has completed before detach") may cause system freeze during suspend. Using async_synchronize_full() in PM callbacks is wrong, since async callbacks that are already scheduled may wait for

[PATCH v3] libata: Use per port sync for detach

2020-06-03 Thread Kai-Heng Feng
Commit 130f4caf145c ("libata: Ensure ata_port probe has completed before detach") may cause system freeze during suspend. Using async_synchronize_full() in PM callbacks is wrong, since async callbacks that are already scheduled may wait for not-yet-scheduled callbacks, causes a circular