Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-14 Thread Matthias Schwarzott
Am 13.07.19 um 12:02 schrieb Mauro Carvalho Chehab: > Em Sat, 13 Jul 2019 00:11:12 +0200 > Marc Gonzalez escreveu: > >> On 12/07/2019 19:45, Mauro Carvalho Chehab wrote: >> >>> Brad Love escreveu: >>> >>> IMHO, using sizeof() here is a very bad idea. >> >> You may have a point... >>

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-13 Thread Mauro Carvalho Chehab
Em Sat, 13 Jul 2019 00:11:12 +0200 Marc Gonzalez escreveu: > On 12/07/2019 19:45, Mauro Carvalho Chehab wrote: > > > Brad Love escreveu: > > > >> On 04/07/2019 05.33, Marc Gonzalez wrote: > >> > >>> +#define CMD_SETUP(cmd, args, rlen) \ > >>> + cmd_setup(cmd, args, sizeof(args) - 1, rlen)

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-12 Thread Marc Gonzalez
On 12/07/2019 19:45, Mauro Carvalho Chehab wrote: > Brad Love escreveu: > >> On 04/07/2019 05.33, Marc Gonzalez wrote: >> >>> +#define CMD_SETUP(cmd, args, rlen) \ >>> + cmd_setup(cmd, args, sizeof(args) - 1, rlen) >>> + >> >> This is only a valid helper if args is a null terminated string.

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-12 Thread Marc Gonzalez
On 12/07/2019 17:47, Brad Love wrote: > On 04/07/2019 05.33, Marc Gonzalez wrote: > >> Refactor the command setup code, and let the compiler determine >> the size of each command. >> >> Reviewed-by: Jonathan Neuschäfer >> Signed-off-by: Marc Gonzalez >> --- >> Changes from v1: >> - Use a real

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-12 Thread Mauro Carvalho Chehab
Em Fri, 12 Jul 2019 10:47:17 -0500 Brad Love escreveu: > Hi Marc, > > Replying inline. > > > On 04/07/2019 05.33, Marc Gonzalez wrote: > > Refactor the command setup code, and let the compiler determine > > the size of each command. > > > > Reviewed-by: Jonathan Neuschäfer > > Signed-off-by:

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-12 Thread Brad Love
Hi Marc, Replying inline. On 04/07/2019 05.33, Marc Gonzalez wrote: > Refactor the command setup code, and let the compiler determine > the size of each command. > > Reviewed-by: Jonathan Neuschäfer > Signed-off-by: Marc Gonzalez > --- > Changes from v1: > - Use a real function to populate

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-12 Thread Marc Gonzalez
+ Sean On 12/07/2019 10:43, Uwe Kleine-König wrote: > On Thu, Jul 04, 2019 at 12:33:22PM +0200, Marc Gonzalez wrote: > >> Refactor the command setup code, and let the compiler determine >> the size of each command. >> >> Reviewed-by: Jonathan Neuschäfer >> Signed-off-by: Marc Gonzalez >> ---

Re: [PATCH v3] media: si2168: Refactor command setup code

2019-07-12 Thread Uwe Kleine-König
Hello, On Thu, Jul 04, 2019 at 12:33:22PM +0200, Marc Gonzalez wrote: > Refactor the command setup code, and let the compiler determine > the size of each command. > > Reviewed-by: Jonathan Neuschäfer > Signed-off-by: Marc Gonzalez > --- > Changes from v1: > - Use a real function to populate

[PATCH v3] media: si2168: Refactor command setup code

2019-07-04 Thread Marc Gonzalez
Refactor the command setup code, and let the compiler determine the size of each command. Reviewed-by: Jonathan Neuschäfer Signed-off-by: Marc Gonzalez --- Changes from v1: - Use a real function to populate struct si2168_cmd *cmd, and a trivial macro wrapping it (macro because sizeof). Changes