Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-15 Thread Lee Jones
On Mon, 15 Mar 2021, Andreas Kemnade wrote: > On Mon, 15 Mar 2021 08:12:31 + > Lee Jones wrote: > > [...] > > > static int ntxec_probe(struct i2c_client *client) > > > { > > > struct ntxec *ec; > > > unsigned int version; > > > int res; > > > + const struct mfd_cell *subdevs = ntxec_

Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-15 Thread Andreas Kemnade
On Mon, 15 Mar 2021 08:12:31 + Lee Jones wrote: [...] > > static int ntxec_probe(struct i2c_client *client) > > { > > struct ntxec *ec; > > unsigned int version; > > int res; > > + const struct mfd_cell *subdevs = ntxec_subdev; > > + size_t n_subdevs = ARRAY_SIZE(ntxec_subde

Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-15 Thread Lee Jones
On Sat, 13 Mar 2021, Andreas Kemnade wrote: > Add the version of the EC in the Tolino Shine 2 HD > to the supported versions. It seems not to have an RTC > and does not ack data written to it. > The vendor kernel happily ignores write errors, using > I2C via userspace i2c-set also shows the error.

Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-13 Thread Jonathan Neuschäfer
On Sat, Mar 13, 2021 at 11:42:58AM +0100, Andreas Kemnade wrote: > Add the version of the EC in the Tolino Shine 2 HD > to the supported versions. It seems not to have an RTC > and does not ack data written to it. > The vendor kernel happily ignores write errors, using > I2C via userspace i2c-set a

[PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-13 Thread Andreas Kemnade
Add the version of the EC in the Tolino Shine 2 HD to the supported versions. It seems not to have an RTC and does not ack data written to it. The vendor kernel happily ignores write errors, using I2C via userspace i2c-set also shows the error. So add a quirk to ignore that error. PWM can be succe