Re: [PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-23 Thread Hugh Dickins
On Wed, 21 Nov 2018, Andrew Morton wrote: > On Wed, 21 Nov 2018 14:54:42 -0700 Yu Zhao wrote: > > > We changed key of swap cache tree from swp_entry_t.val to > > swp_offset. Need to do so in shmem_replace_page() as well. > > What are the user-visible effects of this change? Sorry, I don't

Re: [PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-23 Thread Hugh Dickins
On Wed, 21 Nov 2018, Andrew Morton wrote: > On Wed, 21 Nov 2018 14:54:42 -0700 Yu Zhao wrote: > > > We changed key of swap cache tree from swp_entry_t.val to > > swp_offset. Need to do so in shmem_replace_page() as well. > > What are the user-visible effects of this change? Sorry, I don't

Re: [PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-21 Thread Andrew Morton
On Wed, 21 Nov 2018 14:54:42 -0700 Yu Zhao wrote: > We changed key of swap cache tree from swp_entry_t.val to > swp_offset. Need to do so in shmem_replace_page() as well. What are the user-visible effects of this change? > Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap

Re: [PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-21 Thread Andrew Morton
On Wed, 21 Nov 2018 14:54:42 -0700 Yu Zhao wrote: > We changed key of swap cache tree from swp_entry_t.val to > swp_offset. Need to do so in shmem_replace_page() as well. What are the user-visible effects of this change? > Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap

Re: [PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-21 Thread Hugh Dickins
On Wed, 21 Nov 2018, Yu Zhao wrote: > We changed key of swap cache tree from swp_entry_t.val to > swp_offset. Need to do so in shmem_replace_page() as well. > > Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap > cache") > Cc: sta...@vger.kernel.org # v4.9+ >

Re: [PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-21 Thread Hugh Dickins
On Wed, 21 Nov 2018, Yu Zhao wrote: > We changed key of swap cache tree from swp_entry_t.val to > swp_offset. Need to do so in shmem_replace_page() as well. > > Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap > cache") > Cc: sta...@vger.kernel.org # v4.9+ >

Re: [PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-21 Thread Matthew Wilcox
On Wed, Nov 21, 2018 at 02:54:42PM -0700, Yu Zhao wrote: > We changed key of swap cache tree from swp_entry_t.val to > swp_offset. Need to do so in shmem_replace_page() as well. > > Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap > cache") > Cc: sta...@vger.kernel.org #

Re: [PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-21 Thread Matthew Wilcox
On Wed, Nov 21, 2018 at 02:54:42PM -0700, Yu Zhao wrote: > We changed key of swap cache tree from swp_entry_t.val to > swp_offset. Need to do so in shmem_replace_page() as well. > > Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap > cache") > Cc: sta...@vger.kernel.org #

[PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-21 Thread Yu Zhao
We changed key of swap cache tree from swp_entry_t.val to swp_offset. Need to do so in shmem_replace_page() as well. Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap cache") Cc: sta...@vger.kernel.org # v4.9+ Signed-off-by: Yu Zhao --- mm/shmem.c | 6 -- 1 file

[PATCH v3] mm: use swp_offset as key in shmem_replace_page()

2018-11-21 Thread Yu Zhao
We changed key of swap cache tree from swp_entry_t.val to swp_offset. Need to do so in shmem_replace_page() as well. Fixes: f6ab1f7f6b2d ("mm, swap: use offset of swap entry as key of swap cache") Cc: sta...@vger.kernel.org # v4.9+ Signed-off-by: Yu Zhao --- mm/shmem.c | 6 -- 1 file