Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

From: Gregory CLEMENT Date: Thu, 17 Dec 2015 09:39:32 +0100 > if I remebered well you do not remove patch from yout branch. So would > you agree to take a follow-up patch on top of 5833e0526820 "net/macb: > add support for resetting PHY using GPIO" ? Yes. -- To unsubscribe from this list: send

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

Hi Arnd, On mer., déc. 16 2015, Arnd Bergmann wrote: > On Wednesday 16 December 2015 19:31:30 Gregory CLEMENT wrote: >> diff --git a/drivers/net/ethernet/cadence/macb.c >> b/drivers/net/ethernet/cadence/macb.c >> index 88c1e1a..35661aa 100644 >> --- a/drivers/net/ethernet/cadence/macb.c >>

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

Hi Arnd, On mer., déc. 16 2015, Arnd Bergmann wrote: > On Wednesday 16 December 2015 19:31:30 Gregory CLEMENT wrote: >> diff --git a/drivers/net/ethernet/cadence/macb.c >> b/drivers/net/ethernet/cadence/macb.c >> index 88c1e1a..35661aa 100644 >> ---

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

From: Gregory CLEMENT Date: Thu, 17 Dec 2015 09:39:32 +0100 > if I remebered well you do not remove patch from yout branch. So would > you agree to take a follow-up patch on top of 5833e0526820 "net/macb: > add support for resetting PHY using GPIO" ? Yes. --

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

On Wednesday 16 December 2015 19:31:30 Gregory CLEMENT wrote: > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c > index 88c1e1a..35661aa 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -28,6 +28,7 @@ >

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

Hi Richard, On mer., déc. 16 2015, Richard Cochran wrote: > On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote: >> +Optional properties for PHY child node: >> +- reset-gpios : Should specify the gpio for phy reset > > reset-gpios plural or reset-gpio singular? The bindings name

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote: > +Optional properties for PHY child node: > +- reset-gpios : Should specify the gpio for phy reset reset-gpios plural or reset-gpio singular? > + > Examples: > > macb0: ethernet@fffc4000 { > @@ -29,4 +32,8 @@ Examples: >

[PATCH v3] net/macb: add support for resetting PHY using GPIO

With device tree it is no more possible to reset the PHY at board level. Furthermore, doing in the driver allow to power down the PHY when the network interface is no more used. This reset can't be done at the PHY driver level. The PHY must be able to answer to the mii bus scan to let the kernel

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote: > +Optional properties for PHY child node: > +- reset-gpios : Should specify the gpio for phy reset reset-gpios plural or reset-gpio singular? > + > Examples: > > macb0: ethernet@fffc4000 { > @@ -29,4 +32,8 @@ Examples: >

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

On Wednesday 16 December 2015 19:31:30 Gregory CLEMENT wrote: > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c > index 88c1e1a..35661aa 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -28,6 +28,7 @@ >

[PATCH v3] net/macb: add support for resetting PHY using GPIO

With device tree it is no more possible to reset the PHY at board level. Furthermore, doing in the driver allow to power down the PHY when the network interface is no more used. This reset can't be done at the PHY driver level. The PHY must be able to answer to the mii bus scan to let the kernel

Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO

Hi Richard, On mer., déc. 16 2015, Richard Cochran wrote: > On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote: >> +Optional properties for PHY child node: >> +- reset-gpios : Should specify the gpio for phy reset > > reset-gpios plural or reset-gpio