Re: [PATCH v3] perf sched: fix wrong conversion of task state

2016-07-29 Thread Masami Hiramatsu
On Fri, 29 Jul 2016 13:00:08 +0900 Tomoki Sekiyama wrote: > sched_out_state() converts the prev_state u64 bitmask to a char in > a wrong way, which may cause invalid memory access. > TASK_STATE_TO_CHAR_STR should also be fixed to adapt current > kernel's sched.h.

Re: [PATCH v3] perf sched: fix wrong conversion of task state

2016-07-29 Thread Masami Hiramatsu
On Fri, 29 Jul 2016 13:00:08 +0900 Tomoki Sekiyama wrote: > sched_out_state() converts the prev_state u64 bitmask to a char in > a wrong way, which may cause invalid memory access. > TASK_STATE_TO_CHAR_STR should also be fixed to adapt current > kernel's sched.h. This still have 2 things... >

Re: [PATCH v3] perf sched: fix wrong conversion of task state

2016-07-29 Thread David Ahern
On 7/28/16 10:00 PM, Tomoki Sekiyama wrote: sched_out_state() converts the prev_state u64 bitmask to a char in a wrong way, which may cause invalid memory access. TASK_STATE_TO_CHAR_STR should also be fixed to adapt current kernel's sched.h. Masami's point is that this should be 2 separate

Re: [PATCH v3] perf sched: fix wrong conversion of task state

2016-07-29 Thread David Ahern
On 7/28/16 10:00 PM, Tomoki Sekiyama wrote: sched_out_state() converts the prev_state u64 bitmask to a char in a wrong way, which may cause invalid memory access. TASK_STATE_TO_CHAR_STR should also be fixed to adapt current kernel's sched.h. Masami's point is that this should be 2 separate

[PATCH v3] perf sched: fix wrong conversion of task state

2016-07-28 Thread Tomoki Sekiyama
sched_out_state() converts the prev_state u64 bitmask to a char in a wrong way, which may cause invalid memory access. TASK_STATE_TO_CHAR_STR should also be fixed to adapt current kernel's sched.h. Signed-off-by: Tomoki Sekiyama Cc: Jiri Olsa

[PATCH v3] perf sched: fix wrong conversion of task state

2016-07-28 Thread Tomoki Sekiyama
sched_out_state() converts the prev_state u64 bitmask to a char in a wrong way, which may cause invalid memory access. TASK_STATE_TO_CHAR_STR should also be fixed to adapt current kernel's sched.h. Signed-off-by: Tomoki Sekiyama Cc: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter