Re: [PATCH v3] pinctrl/pinconfig: add debug interface

2013-04-19 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:52 PM, Russell King - ARM Linux wrote: > On Thu, Apr 18, 2013 at 12:35:14PM +0200, Linus Walleij wrote: >> + if (map->type != dbg->map_type) >> + continue; >> + if (!!strcmp(map->dev_name, dbg->dev_name)) > > !! is pointless

Re: [PATCH v3] pinctrl/pinconfig: add debug interface

2013-04-19 Thread Linus Walleij
On Thu, Apr 18, 2013 at 12:52 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Apr 18, 2013 at 12:35:14PM +0200, Linus Walleij wrote: + if (map-type != dbg-map_type) + continue; + if (!!strcmp(map-dev_name, dbg-dev_name)) !! is

Re: [PATCH v3] pinctrl/pinconfig: add debug interface

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 12:35:14PM +0200, Linus Walleij wrote: > + if (map->type != dbg->map_type) > + continue; > + if (!!strcmp(map->dev_name, dbg->dev_name)) !! is pointless in this context - if() evaluates any non-zero value as true, so there's no

[PATCH v3] pinctrl/pinconfig: add debug interface

2013-04-18 Thread Linus Walleij
From: Laurent Meunier This update adds a debugfs interface to modify a pin configuration for a given state in the pinctrl map. This allows to modify the configuration for a non-active state, typically sleep state. This configuration is not applied right away, but only when the state will be

[PATCH v3] pinctrl/pinconfig: add debug interface

2013-04-18 Thread Linus Walleij
From: Laurent Meunier laurent.meun...@st.com This update adds a debugfs interface to modify a pin configuration for a given state in the pinctrl map. This allows to modify the configuration for a non-active state, typically sleep state. This configuration is not applied right away, but only when

Re: [PATCH v3] pinctrl/pinconfig: add debug interface

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 12:35:14PM +0200, Linus Walleij wrote: + if (map-type != dbg-map_type) + continue; + if (!!strcmp(map-dev_name, dbg-dev_name)) !! is pointless in this context - if() evaluates any non-zero value as true, so there's no point