Re: [PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2019-01-23 Thread Enric Balletbo Serra
Missatge de Moritz Fischer del dia dt., 22 de gen. 2019 a les 22:09: > > Hi Enrico, > > On Mon, Jan 21, 2019 at 11:19:34PM +0100, Enric Balletbo Serra wrote: > > I tried with a Samsung Chromebook Plus (arm64 Chromebook) > > > > > What was the ioctl you ran? > > > > > > > The code that I ran is

Re: [PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2019-01-22 Thread Moritz Fischer
Hi Enrico, On Mon, Jan 21, 2019 at 11:19:34PM +0100, Enric Balletbo Serra wrote: > I tried with a Samsung Chromebook Plus (arm64 Chromebook) > > > What was the ioctl you ran? > > > > The code that I ran is this: https://hastebin.com/cupecuvowi.py > No guarantee :) I'll try to look deeper

Re: [PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2019-01-21 Thread Enric Balletbo Serra
Hi Moritz, Missatge de Moritz Fischer del dia dl., 21 de gen. 2019 a les 19:40: > > Hi Enrico, > > On Mon, Jan 21, 2019 at 06:32:48PM +0100, Enric Balletbo Serra wrote: > > Hi Moritz, > > > > Missatge de Moritz Fischer del dia dj., 10 de gen. > > 2019 a les 5:40: > > > > > > Add

Re: [PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2019-01-21 Thread Moritz Fischer
Hi Enrico, On Mon, Jan 21, 2019 at 06:32:48PM +0100, Enric Balletbo Serra wrote: > Hi Moritz, > > Missatge de Moritz Fischer del dia dj., 10 de gen. > 2019 a les 5:40: > > > > Add cros_ec_readmem() helpers for I2C/SPI based ECs. > > Unlike the LPC based ECs the I2C/SPI based ones cannot just

Re: [PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2019-01-21 Thread Enric Balletbo Serra
Hi Moritz, Missatge de Moritz Fischer del dia dj., 10 de gen. 2019 a les 5:40: > > Add cros_ec_readmem() helpers for I2C/SPI based ECs. > Unlike the LPC based ECs the I2C/SPI based ones cannot just directly > read the mapped region, but have to resort to EC_CMD_READ_MEMMAP. > > This is useful

[PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2019-01-09 Thread Moritz Fischer
Add cros_ec_readmem() helpers for I2C/SPI based ECs. Unlike the LPC based ECs the I2C/SPI based ones cannot just directly read the mapped region, but have to resort to EC_CMD_READ_MEMMAP. This is useful for things like accessing fan speeds or temperatures. Signed-off-by: Moritz Fischer --- Hi