Re: [PATCH v3] platform/chrome: wilco_ec: Add h1_gpio status to debugfs

2019-04-11 Thread Nick Crews
Thanks for the comments Enric! I'll resend in a day or two. On Thu, Apr 11, 2019 at 3:43 PM Enric Balletbo Serra wrote: > > Hi Nick, > > Some comments below ... > > Missatge de Nick Crews del dia dj., 11 d’abr. > 2019 a les 0:09: > > > > As part of Chrome OS's FAFT (Fully Automated Firmware

Re: [PATCH v3] platform/chrome: wilco_ec: Add h1_gpio status to debugfs

2019-04-11 Thread Enric Balletbo Serra
Hi Nick, Some comments below ... Missatge de Nick Crews del dia dj., 11 d’abr. 2019 a les 0:09: > > As part of Chrome OS's FAFT (Fully Automated Firmware Testing) > tests, we need to ensure that the H1 chip is properly setting > some GPIO lines. The h1_gpio attribute exposes the state > of the

[PATCH v3] platform/chrome: wilco_ec: Add h1_gpio status to debugfs

2019-04-10 Thread Nick Crews
As part of Chrome OS's FAFT (Fully Automated Firmware Testing) tests, we need to ensure that the H1 chip is properly setting some GPIO lines. The h1_gpio attribute exposes the state of the lines: - ENTRY_TO_FACT_MODE in BIT(0) - SPI_CHROME_SEL in BIT(1) There are two reasons that I am exposing