Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-07 Thread Laurentiu Palcu
Hi Anda, On Wed, May 06, 2015 at 06:41:00PM +0300, Anda-Maria Nicolae wrote: (...) > >>Updates from v2 version: > >>- removed unused masks and keep the used ones. I have tried to access mask > >>field > >>from struct regmap_field, but I have received the following compilation > >>error: >

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-07 Thread Laurentiu Palcu
Hi Anda, On Wed, May 06, 2015 at 06:41:00PM +0300, Anda-Maria Nicolae wrote: (...) Updates from v2 version: - removed unused masks and keep the used ones. I have tried to access mask field from struct regmap_field, but I have received the following compilation error: dereferencing pointer

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Anda-Maria Nicolae
On 05/06/2015 10:58 AM, Krzysztof Kozłowski wrote: 2015-05-06 1:32 GMT+09:00 Anda-Maria Nicolae : Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae --- Updates from v2 version: - removed unused masks and keep the used ones.

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Anda-Maria Nicolae
Hi Laurentiu, Inline are the answers to your comments. Thanks, Anda On 05/06/2015 02:40 PM, Laurentiu Palcu wrote: On Tue, May 05, 2015 at 07:32:10PM +0300, Anda-Maria Nicolae wrote: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Krzysztof Kozłowski
2015-05-06 20:40 GMT+09:00 Laurentiu Palcu : > On Tue, May 05, 2015 at 07:32:10PM +0300, Anda-Maria Nicolae wrote: >> +static int rt9455_probe(struct i2c_client *client, >> + const struct i2c_device_id *id) >> +{ >> + struct i2c_adapter *adapter =

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Laurentiu Palcu
On Tue, May 05, 2015 at 07:32:10PM +0300, Anda-Maria Nicolae wrote: > Based on the datasheet found here: > http://www.richtek.com/download_ds.jsp?p=RT9455 > > Signed-off-by: Anda-Maria Nicolae > --- > > Updates from v2 version: > - removed unused masks and keep the used ones. I have tried to

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Krzysztof Kozłowski
2015-05-06 1:32 GMT+09:00 Anda-Maria Nicolae : > Based on the datasheet found here: > http://www.richtek.com/download_ds.jsp?p=RT9455 > > Signed-off-by: Anda-Maria Nicolae > --- > > Updates from v2 version: > - removed unused masks and keep the used ones. I have tried to access mask > field >

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Krzysztof Kozłowski
2015-05-06 1:32 GMT+09:00 Anda-Maria Nicolae anda-maria.nico...@intel.com: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v2 version: - removed unused masks and keep the used

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Laurentiu Palcu
On Tue, May 05, 2015 at 07:32:10PM +0300, Anda-Maria Nicolae wrote: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v2 version: - removed unused masks and keep the used

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Krzysztof Kozłowski
2015-05-06 20:40 GMT+09:00 Laurentiu Palcu laurentiu.pa...@intel.com: On Tue, May 05, 2015 at 07:32:10PM +0300, Anda-Maria Nicolae wrote: +static int rt9455_probe(struct i2c_client *client, + const struct i2c_device_id *id) +{ + struct i2c_adapter *adapter =

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Anda-Maria Nicolae
Hi Laurentiu, Inline are the answers to your comments. Thanks, Anda On 05/06/2015 02:40 PM, Laurentiu Palcu wrote: On Tue, May 05, 2015 at 07:32:10PM +0300, Anda-Maria Nicolae wrote: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria

Re: [PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-06 Thread Anda-Maria Nicolae
On 05/06/2015 10:58 AM, Krzysztof Kozłowski wrote: 2015-05-06 1:32 GMT+09:00 Anda-Maria Nicolae anda-maria.nico...@intel.com: Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v2

[PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-05 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae --- Updates from v2 version: - removed unused masks and keep the used ones. I have tried to access mask field from struct regmap_field, but I have received the following

[PATCH v3] power_supply: Add support for Richtek rt9455 battery charger

2015-05-05 Thread Anda-Maria Nicolae
Based on the datasheet found here: http://www.richtek.com/download_ds.jsp?p=RT9455 Signed-off-by: Anda-Maria Nicolae anda-maria.nico...@intel.com --- Updates from v2 version: - removed unused masks and keep the used ones. I have tried to access mask field from struct regmap_field, but I have