Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Mark Brown
On Thu, May 07, 2015 at 02:38:52PM -0500, Michael Welling wrote: > On Thu, May 07, 2015 at 08:27:58PM +0100, Mark Brown wrote: > > On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote: > > > On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote: > > > I noticed a few oddities in

Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Michael Welling
On Thu, May 07, 2015 at 08:27:58PM +0100, Mark Brown wrote: > On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote: > > On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote: > > > > makes things easier to review and helps people trying to understand the > > > Do you have any

Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Mark Brown
On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote: > On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote: > > makes things easier to review and helps people trying to understand the > Do you have any other suggestions or comments on the patch so that I > can incorporate

Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Michael Welling
On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote: > On Wed, May 06, 2015 at 06:37:52PM -0500, Michael Welling wrote: > > This patch allows for GPIOs specified in the devicetree to be used as SPI > > chipselects on TI OMAP2 SoCs. > > > > Tested on the AM3354. > > > > Signed-off-by:

Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Mark Brown
On Wed, May 06, 2015 at 06:37:52PM -0500, Michael Welling wrote: > This patch allows for GPIOs specified in the devicetree to be used as SPI > chipselects on TI OMAP2 SoCs. > > Tested on the AM3354. > > Signed-off-by: Michael Welling > --- > v3: Switches driver to use transfer_one instead of

Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Michael Welling
On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote: On Wed, May 06, 2015 at 06:37:52PM -0500, Michael Welling wrote: This patch allows for GPIOs specified in the devicetree to be used as SPI chipselects on TI OMAP2 SoCs. Tested on the AM3354. Signed-off-by: Michael Welling

Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Mark Brown
On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote: On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote: makes things easier to review and helps people trying to understand the Do you have any other suggestions or comments on the patch so that I can incorporate those

Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Mark Brown
On Thu, May 07, 2015 at 02:38:52PM -0500, Michael Welling wrote: On Thu, May 07, 2015 at 08:27:58PM +0100, Mark Brown wrote: On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote: On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote: I noticed a few oddities in the code

Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Mark Brown
On Wed, May 06, 2015 at 06:37:52PM -0500, Michael Welling wrote: This patch allows for GPIOs specified in the devicetree to be used as SPI chipselects on TI OMAP2 SoCs. Tested on the AM3354. Signed-off-by: Michael Welling mwell...@ieee.org --- v3: Switches driver to use transfer_one

Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-07 Thread Michael Welling
On Thu, May 07, 2015 at 08:27:58PM +0100, Mark Brown wrote: On Thu, May 07, 2015 at 02:20:19PM -0500, Michael Welling wrote: On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote: makes things easier to review and helps people trying to understand the Do you have any other

[PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-06 Thread Michael Welling
This patch allows for GPIOs specified in the devicetree to be used as SPI chipselects on TI OMAP2 SoCs. Tested on the AM3354. Signed-off-by: Michael Welling --- v3: Switches driver to use transfer_one instead of transfer_one_message allowing the spi core to handle toggling GPIO chip selects if

[PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects

2015-05-06 Thread Michael Welling
This patch allows for GPIOs specified in the devicetree to be used as SPI chipselects on TI OMAP2 SoCs. Tested on the AM3354. Signed-off-by: Michael Welling mwell...@ieee.org --- v3: Switches driver to use transfer_one instead of transfer_one_message allowing the spi core to handle toggling GPIO