Re: [PATCH v3] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

2018-10-08 Thread Mika Westerberg
On Fri, Oct 05, 2018 at 12:25:09PM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another. > > drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from > enumeration type 'enum dma_transfer_direction' to different enumeration > type

Re: [PATCH v3] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

2018-10-08 Thread Mika Westerberg
On Fri, Oct 05, 2018 at 12:25:09PM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another. > > drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from > enumeration type 'enum dma_transfer_direction' to different enumeration > type

Re: [PATCH v3] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Nathan Chancellor
On Fri, Oct 05, 2018 at 01:41:19PM -0700, Nick Desaulniers wrote: > Nathan, > Thanks for your patience and continued support working towards an > optimal solution to fix this warning. Some thoughts below. > > On Fri, Oct 5, 2018 at 12:29 PM Nathan Chancellor > wrote: > > > > Clang warns when one

Re: [PATCH v3] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Nathan Chancellor
On Fri, Oct 05, 2018 at 01:41:19PM -0700, Nick Desaulniers wrote: > Nathan, > Thanks for your patience and continued support working towards an > optimal solution to fix this warning. Some thoughts below. > > On Fri, Oct 5, 2018 at 12:29 PM Nathan Chancellor > wrote: > > > > Clang warns when one

Re: [PATCH v3] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Nick Desaulniers
Nathan, Thanks for your patience and continued support working towards an optimal solution to fix this warning. Some thoughts below. On Fri, Oct 5, 2018 at 12:29 PM Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another. > >

Re: [PATCH v3] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Nick Desaulniers
Nathan, Thanks for your patience and continued support working towards an optimal solution to fix this warning. Some thoughts below. On Fri, Oct 5, 2018 at 12:29 PM Nathan Chancellor wrote: > > Clang warns when one enumerated type is implicitly converted to another. > >

[PATCH v3] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from enumeration type 'enum dma_transfer_direction' to different enumeration type 'enum dma_data_direction' [-Wenum-conversion] nents =

[PATCH v3] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

2018-10-05 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another. drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from enumeration type 'enum dma_transfer_direction' to different enumeration type 'enum dma_data_direction' [-Wenum-conversion] nents =