Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-20 Thread Joe Perches
On Sun, 2018-08-19 at 13:34 +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > > Fixed four debug macros and their usages. Replaced printk with > > dev_ without __func__ or __LINE__ or current->comm and > > current->pid. Further removed the do {}

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-20 Thread Joe Perches
On Sun, 2018-08-19 at 13:34 +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > > Fixed four debug macros and their usages. Replaced printk with > > dev_ without __func__ or __LINE__ or current->comm and > > current->pid. Further removed the do {}

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-20 Thread Nishad Kamdar
On Sun, Aug 19, 2018 at 01:34:01PM +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > > Fixed four debug macros and their usages. Replaced printk with > > dev_ without __func__ or __LINE__ or current->comm and > > current->pid. Further removed the

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-20 Thread Nishad Kamdar
On Sun, Aug 19, 2018 at 01:34:01PM +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > > Fixed four debug macros and their usages. Replaced printk with > > dev_ without __func__ or __LINE__ or current->comm and > > current->pid. Further removed the

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-20 Thread Dan Carpenter
On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > #define N_MSG(evt, fmt, args...) > /* > -do {\ > -if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \ > -printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \ > -host->id, ##args ,

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-20 Thread Dan Carpenter
On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > #define N_MSG(evt, fmt, args...) > /* > -do {\ > -if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \ > -printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \ > -host->id, ##args ,

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-19 Thread Greg Kroah-Hartman
On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > Fixed four debug macros and their usages. Replaced printk with > dev_ without __func__ or __LINE__ or current->comm and > current->pid. Further removed the do {} while(0) loop for single > statement macros. > Out of the four,

Re: [PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-19 Thread Greg Kroah-Hartman
On Sun, Aug 19, 2018 at 03:35:02PM +0530, Nishad Kamdar wrote: > Fixed four debug macros and their usages. Replaced printk with > dev_ without __func__ or __LINE__ or current->comm and > current->pid. Further removed the do {} while(0) loop for single > statement macros. > Out of the four,

[PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-19 Thread Nishad Kamdar
Fixed four debug macros and their usages. Replaced printk with dev_ without __func__ or __LINE__ or current->comm and current->pid. Further removed the do {} while(0) loop for single statement macros. Out of the four, replaced all usages of ERR_MSG and IRQ_MSG with dev_err() in the code itself and

[PATCH v3] staging: mt7621-mmc: Fix debug macros and their usages

2018-08-19 Thread Nishad Kamdar
Fixed four debug macros and their usages. Replaced printk with dev_ without __func__ or __LINE__ or current->comm and current->pid. Further removed the do {} while(0) loop for single statement macros. Out of the four, replaced all usages of ERR_MSG and IRQ_MSG with dev_err() in the code itself and