Re: [PATCH v3] uprobes: simplify rip-relative handling

2014-04-30 Thread Jim Keniston
On Mon, 2014-04-28 at 19:06 +0200, Denys Vlasenko wrote: > It is possible to replace rip-relative addressing mode > with addressing mode of the same length: (reg+disp32). > This eliminates the need to fix up immediate > and correct for changing instruction length. > > v2: Rebased on top of Oleg's

Re: [PATCH v3] uprobes: simplify rip-relative handling

2014-04-30 Thread Jim Keniston
On Mon, 2014-04-28 at 19:06 +0200, Denys Vlasenko wrote: It is possible to replace rip-relative addressing mode with addressing mode of the same length: (reg+disp32). This eliminates the need to fix up immediate and correct for changing instruction length. v2: Rebased on top of Oleg's

Re: [PATCH v3] uprobes: simplify rip-relative handling

2014-04-29 Thread Oleg Nesterov
This version looks fine to me. Masami, Jim, Srikar, can you ack the change in riprel_analyze() ? On 04/28, Denys Vlasenko wrote: > > It is possible to replace rip-relative addressing mode > with addressing mode of the same length: (reg+disp32). > This eliminates the need to fix up immediate >

Re: [PATCH v3] uprobes: simplify rip-relative handling

2014-04-29 Thread Oleg Nesterov
This version looks fine to me. Masami, Jim, Srikar, can you ack the change in riprel_analyze() ? On 04/28, Denys Vlasenko wrote: It is possible to replace rip-relative addressing mode with addressing mode of the same length: (reg+disp32). This eliminates the need to fix up immediate and