Re: [PATCH v3] vfs: don't evict uninitialized inode

On Wed, Aug 22, 2018 at 4:37 PM, Marc Dionne wrote: > > FYI with this patch (now merged) I'm seeing warnings whenever an > object is created in an overlayfs mount: > > [ 842.152673] list_add double add: new=88017efe03d8, > prev=88015c07ad88, next=88017efe03d8. > [ 842.152687]

Re: [PATCH v3] vfs: don't evict uninitialized inode

On Wed, Aug 22, 2018 at 4:37 PM, Marc Dionne wrote: > > FYI with this patch (now merged) I'm seeing warnings whenever an > object is created in an overlayfs mount: > > [ 842.152673] list_add double add: new=88017efe03d8, > prev=88015c07ad88, next=88017efe03d8. > [ 842.152687]

Re: [PATCH v3] vfs: don't evict uninitialized inode

On Tue, Jul 24, 2018 at 10:01 AM, Miklos Szeredi wrote: > iput() ends up calling ->evict() on new inode, which is not yet initialized > by owning fs. So use destroy_inode() instead. > > Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning > that it wasn't allocated with

Re: [PATCH v3] vfs: don't evict uninitialized inode

On Tue, Jul 24, 2018 at 10:01 AM, Miklos Szeredi wrote: > iput() ends up calling ->evict() on new inode, which is not yet initialized > by owning fs. So use destroy_inode() instead. > > Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning > that it wasn't allocated with

[PATCH v3] vfs: don't evict uninitialized inode

iput() ends up calling ->evict() on new inode, which is not yet initialized by owning fs. So use destroy_inode() instead. Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning that it wasn't allocated with new_inode(), which already does the insertion). Reported-by: Al Viro

[PATCH v3] vfs: don't evict uninitialized inode

iput() ends up calling ->evict() on new inode, which is not yet initialized by owning fs. So use destroy_inode() instead. Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning that it wasn't allocated with new_inode(), which already does the insertion). Reported-by: Al Viro