Re: [PATCH v3] x86: mm: Do not use set_{pud,pmd}_safe when splitting the large page

Hi Boris, On 4/17/19 12:24 PM, Dave Hansen wrote: ... > > The comment here is missing one key point: > kernel_physical_mapping_init() can only be used to populate non-present > entries. It kinda infers that from "Create...", but I really think we > need to be explicit. > > Anyway, it's better

Re: [PATCH v3] x86: mm: Do not use set_{pud,pmd}_safe when splitting the large page

On 4/17/19 8:41 AM, Singh, Brijesh wrote: > Changes since v2: > - rename variable safe->init > - rename __set_* -> set_*_init() > - remame __*_populate -> *_populate_init() "init" in this context really means "setting non-present PTEs is OK, but changing present ones is not". It still doesn't do

[PATCH v3] x86: mm: Do not use set_{pud,pmd}_safe when splitting the large page

The following commit 0a9fe8ca844d ("x86/mm: Validate kernel_physical_mapping_init() PTE population") triggers the below warning in the SEV guest. WARNING: CPU: 0 PID: 0 at arch/x86/include/asm/pgalloc.h:87 phys_pmd_init+0x30d/0x386 Call Trace: kernel_physical_mapping_init+0xce/0x259