Re: [PATCH v3 0/5] mm/memcg: Reduce kmemcache memory accounting overhead

2021-04-15 Thread Waiman Long
On 4/15/21 1:10 PM, Matthew Wilcox wrote: On Tue, Apr 13, 2021 at 09:20:22PM -0400, Waiman Long wrote: With memory accounting disable, the run time was 2.848s. With memory accounting enabled, the run times with the application of various patches in the patchset were: Applied patches Run

Re: [PATCH v3 0/5] mm/memcg: Reduce kmemcache memory accounting overhead

2021-04-15 Thread Matthew Wilcox
On Tue, Apr 13, 2021 at 09:20:22PM -0400, Waiman Long wrote: > With memory accounting disable, the run time was 2.848s. With memory > accounting enabled, the run times with the application of various > patches in the patchset were: > > Applied patches Run time Accounting overhead Overhead

Re: [PATCH v3 0/5] mm/memcg: Reduce kmemcache memory accounting overhead

2021-04-15 Thread Masayoshi Mizuma
On Thu, Apr 15, 2021 at 09:17:37AM -0400, Waiman Long wrote: > I was focusing on your kernel module benchmark in testing my patch. I will > try out your pgbench benchmark to see if there can be other tuning that can > be done. Thanks a lot! > BTW, how many numa nodes does your test machine? I

Re: [PATCH v3 0/5] mm/memcg: Reduce kmemcache memory accounting overhead

2021-04-15 Thread Waiman Long
On 4/14/21 11:26 PM, Masayoshi Mizuma wrote: Hi Longman, Thank you for your patches. I rerun the benchmark with your patches, it seems that the reduction is small... The total duration of sendto() and recvfrom() system call during the benchmark are as follows. - sendto - v5.8 vanilla:

Re: [PATCH v3 0/5] mm/memcg: Reduce kmemcache memory accounting overhead

2021-04-14 Thread Masayoshi Mizuma
On Tue, Apr 13, 2021 at 09:20:22PM -0400, Waiman Long wrote: > v3: > - Add missing "inline" qualifier to the alternate mod_obj_stock_state() > in patch 3. > - Remove redundant current_obj_stock() call in patch 5. > > v2: > - Fix bug found by test robot in patch 5. > - Update cover

[PATCH v3 0/5] mm/memcg: Reduce kmemcache memory accounting overhead

2021-04-13 Thread Waiman Long
v3: - Add missing "inline" qualifier to the alternate mod_obj_stock_state() in patch 3. - Remove redundant current_obj_stock() call in patch 5. v2: - Fix bug found by test robot in patch 5. - Update cover letter and commit logs. With the recent introduction of the new slab memory